Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.mrozek@intel.com, balasubramani.vivekanandan@intel.com,
	jose.souza@intel.com, paulo.r.zanoni@intel.com
Subject: [PATCH] drm/xe: Mark ComputeCS read mode as UC on iGPU
Date: Thu, 12 Dec 2024 15:46:06 -0800	[thread overview]
Message-ID: <20241212234606.2877233-1-matthew.brost@intel.com> (raw)

RING_CMD_CCTL read index should be UC on iGPU parts due to L3 caching
structure. Having this as WB blocks ULLS from being enabled. Change to
UC to unblock ULLS on iGPU.

Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Cc: Michal Mrozek <michal.mrozek@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: stable@vger.kernel.org
Fixes: 328e089bfb37 ("drm/xe: Leverage ComputeCS read L3 caching")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index b19366744148..cc258b2a77c9 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -417,9 +417,14 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)
 	 * entry is recommended by the spec in certain circumstances on
 	 * specific platforms.
 	 * Bspec: 72161
+	 *
+	 * XXX: According to internal communications bspec is wrong and
+	 * RING_CMD_CCTL read index should be UC on iGPU parts due to L3 caching
+	 * structure. Having this as WB blocks ULLS from being enabled. Add
+	 * bspec link or delete this comment once bspec is updated.
 	 */
 	const u8 mocs_write_idx = gt->mocs.uc_index;
-	const u8 mocs_read_idx = hwe->class == XE_ENGINE_CLASS_COMPUTE &&
+	const u8 mocs_read_idx = hwe->class == XE_ENGINE_CLASS_COMPUTE && IS_DGFX(xe) &&
 				 (GRAPHICS_VER(xe) >= 20 || xe->info.platform == XE_PVC) ?
 				 gt->mocs.wb_index : gt->mocs.uc_index;
 	u32 ring_cmd_cctl_val = REG_FIELD_PREP(CMD_CCTL_WRITE_OVERRIDE_MASK, mocs_write_idx) |
-- 
2.34.1


             reply	other threads:[~2024-12-12 23:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 23:46 Matthew Brost [this message]
2024-12-13  0:20 ` ✓ CI.Patch_applied: success for drm/xe: Mark ComputeCS read mode as UC on iGPU Patchwork
2024-12-13  0:20 ` ✓ CI.checkpatch: " Patchwork
2024-12-13  0:21 ` ✓ CI.KUnit: " Patchwork
2024-12-13  0:39 ` ✓ CI.Build: " Patchwork
2024-12-13  0:42 ` ✓ CI.Hooks: " Patchwork
2024-12-13  0:43 ` ✓ CI.checksparse: " Patchwork
2024-12-13  1:14 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-13  4:13 ` [PATCH] " Mrozek, Michal
2024-12-13  8:39 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-01-13 23:50   ` Summers, Stuart
2025-01-13 23:57 ` [PATCH] " Summers, Stuart
2025-01-14  0:11   ` Summers, Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241212234606.2877233-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=balasubramani.vivekanandan@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=michal.mrozek@intel.com \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox