Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com, alex.zuo@intel.com
Subject: [PATCH] drm/i915/display: Do not report timeout on suspend
Date: Fri, 13 Dec 2024 23:12:34 +0000	[thread overview]
Message-ID: <20241213231234.81647-1-jonathan.cavitt@intel.com> (raw)

In intel_dp_aux_wait_done, we call intel_de_wait_custom.  This call has
a 10ms timeout before reporting ETIMEDOUT.  However, if the display pm
runtime is suspended, then it would be expected for this call to time
out.  This may be the case, for example, during an engine reset.

Do not report ETIMEDOUT here when the pm runtime is suspended.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 04a7acd7f73c..25c37398f930 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -66,7 +66,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
 				   0,
 				   2, timeout_ms, &status);
 
-	if (ret == -ETIMEDOUT)
+	if (ret == -ETIMEDOUT && !pm_runtime_suspended(display->drm->dev))
 		drm_err(display->drm,
 			"%s: did not complete or timeout within %ums (status 0x%08x)\n",
 			intel_dp->aux.name, timeout_ms, status);
-- 
2.43.0


             reply	other threads:[~2024-12-13 23:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 23:12 Jonathan Cavitt [this message]
2024-12-14  0:16 ` ✓ CI.Patch_applied: success for drm/i915/display: Do not report timeout on suspend Patchwork
2024-12-14  0:16 ` ✓ CI.checkpatch: " Patchwork
2024-12-14  0:17 ` ✓ CI.KUnit: " Patchwork
2024-12-14  0:35 ` ✓ CI.Build: " Patchwork
2024-12-14  0:37 ` ✓ CI.Hooks: " Patchwork
2024-12-14  0:39 ` ✓ CI.checksparse: " Patchwork
2024-12-14  1:15 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-14 19:35 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-16 11:28 ` [PATCH] " Jani Nikula
2024-12-16 11:28 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213231234.81647-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=saurabhg.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox