From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: dnyaneshwar.bhadane@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH] Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link"
Date: Fri, 3 Jan 2025 14:15:17 +0530 [thread overview]
Message-ID: <20250103084517.239998-1-suraj.kandpal@intel.com> (raw)
This reverts commit 483f7d94a0453564ad9295288c0242136c5f36a0.
This needs to be reverted since HDCP even after updating the connector
state HDCP property we don't reenable HDCP until the next commit
in which the CP Property is set causing compliance to fail.
--v2
-Fix build issue [Dnyaneshwar]
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index f6e68a0e3b6d..7464b44c8bb3 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -1166,9 +1166,15 @@ static int intel_hdcp_check_link(struct intel_connector *connector)
goto out;
}
- intel_hdcp_update_value(connector,
- DRM_MODE_CONTENT_PROTECTION_DESIRED,
- true);
+ ret = intel_hdcp1_enable(connector);
+ if (ret) {
+ drm_err(display->drm, "Failed to enable hdcp (%d)\n", ret);
+ intel_hdcp_update_value(connector,
+ DRM_MODE_CONTENT_PROTECTION_DESIRED,
+ true);
+ goto out;
+ }
+
out:
mutex_unlock(&dig_port->hdcp_mutex);
mutex_unlock(&hdcp->mutex);
--
2.34.1
next reply other threads:[~2025-01-03 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 8:45 Suraj Kandpal [this message]
2025-01-03 9:49 ` ✓ CI.Patch_applied: success for Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link" (rev2) Patchwork
2025-01-03 9:49 ` ✓ CI.checkpatch: " Patchwork
2025-01-03 9:50 ` ✓ CI.KUnit: " Patchwork
2025-01-03 10:08 ` ✓ CI.Build: " Patchwork
2025-01-03 10:10 ` ✓ CI.Hooks: " Patchwork
2025-01-03 10:12 ` ✓ CI.checksparse: " Patchwork
2025-01-03 10:37 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-03 12:38 ` [PATCH] Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link" Bhadane, Dnyaneshwar
2025-01-07 19:13 ` Rodrigo Vivi
2025-01-03 13:30 ` ✗ Xe.CI.Full: failure for Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link" (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-12-20 5:01 [PATCH] Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link" Suraj Kandpal
2025-01-03 8:34 ` Bhadane, Dnyaneshwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103084517.239998-1-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=dnyaneshwar.bhadane@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox