Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Filipchuk <julia.filipchuk@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Subject: [PATCH v2] drm/xe/guc: Fix GuC log/ct output via debugfs
Date: Tue,  7 Jan 2025 10:10:17 -0800	[thread overview]
Message-ID: <20250107181017.2639339-1-julia.filipchuk@intel.com> (raw)

Change to disable asci85 GuC logging only when output to devcoredump (was temporarily
disabled for all code paths).

v2: Ignore only for devcoredump case (not dmsg output). (feedback by Lucas)

Signed-off-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 8 +++++---
 include/drm/drm_print.h             | 2 ++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 6980304c8903..8e5d1f9866a7 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -424,10 +424,12 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
 	 * Splitting blobs across multiple lines is not compatible with the mesa
 	 * debug decoder tool. Note that even dropping the explicit '\n' below
 	 * doesn't help because the GuC log is so big some underlying implementation
-	 * still splits the lines at 512K characters. So just bail completely for
-	 * the moment.
+	 * still splits the lines at 512K characters.
+	 *
+	 * Only disable from devcoredump output.
 	 */
-	return;
+	if (p->coredump)
+		return;
 
 #define DMESG_MAX_LINE_LEN	800
 #define MIN_SPACE		(ASCII85_BUFSZ + 2)		/* 85 + "\n\0" */
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index f77fe1531cf8..f5ea7f38ba09 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -182,6 +182,7 @@ struct drm_printer {
 		unsigned int counter;
 	} line;
 	enum drm_debug_category category;
+	bool coredump;
 };
 
 void __drm_printfn_coredump(struct drm_printer *p, struct va_format *vaf);
@@ -335,6 +336,7 @@ drm_coredump_printer(struct drm_print_iterator *iter)
 		.printfn = __drm_printfn_coredump,
 		.puts = __drm_puts_coredump,
 		.arg = iter,
+		.coredump = true,
 	};
 
 	/* Set the internal offset of the iterator to zero */
-- 
2.47.1


             reply	other threads:[~2025-01-07 18:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 18:10 Julia Filipchuk [this message]
2025-01-07 19:13 ` ✓ CI.Patch_applied: success for drm/xe/guc: Fix GuC log/ct output via debugfs (rev2) Patchwork
2025-01-07 19:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-07 19:15 ` ✓ CI.KUnit: success " Patchwork
2025-01-07 19:33 ` ✓ CI.Build: " Patchwork
2025-01-07 19:35 ` ✓ CI.Hooks: " Patchwork
2025-01-07 19:38 ` ✓ CI.checksparse: " Patchwork
2025-01-07 20:03 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-09  6:35 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-09  9:23 ` [PATCH v2] drm/xe/guc: Fix GuC log/ct output via debugfs Maciej Patelczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107181017.2639339-1-julia.filipchuk@intel.com \
    --to=julia.filipchuk@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox