From: Arun R Murthy <arun.r.murthy@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: dmitry.baryshkov@linaro.org, suraj.kandpal@intel.com,
uma.shankar@intel.com,
"Imported from f20241218-dpst-v7-0-81bfe7d08c2d"@intel.com,
20240705091333.328322-1-mohammed.thasleem@intel.com,
Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH v7 11/14] drm/i915/crtc: Hook i915 IET LUT with the drm IET properties
Date: Fri, 10 Jan 2025 01:15:39 +0530 [thread overview]
Message-ID: <20250110-dpst-v7-11-605cb0271162@intel.com> (raw)
In-Reply-To: <20250110-dpst-v7-0-605cb0271162@intel.com>
Upon drm getting the IET LUT value from the user through the IET_LUT
property, i915 driver will write the LUT table to the hardware
registers.
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 3 +++
drivers/gpu/drm/i915/display/intel_display.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 619aa363724602d4084184bfdf5766b71aed1b9f..8c1527ae348083c9d8af7cbbbe188ed18afb0a43 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -387,6 +387,9 @@ int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
if (drm_crtc_create_histogram_property(&crtc->base,
crtc->histogram->caps))
drm_err(&dev_priv->drm, "Failed to initialize histogram properties\n");
+ if (drm_crtc_create_iet_lut_property(&crtc->base,
+ crtc->histogram->iet_caps))
+ drm_err(&dev_priv->drm, "Failed to initialize histogram properties\n");
intel_color_crtc_init(crtc);
intel_drrs_crtc_init(crtc);
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 486992a2caadebf2d3deb200b01d2d0d26b26cb0..dfa0b214a54b5336d45e965282b7d8017f68bafa 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7890,6 +7890,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
intel_histogram_update(crtc,
(struct drm_histogram_config *)
new_crtc_state->uapi.histogram_enable->data);
+ if (new_crtc_state->uapi.iet_lut_updated)
+ intel_histogram_set_iet_lut(crtc, new_crtc_state->uapi.iet_lut);
}
/* Underruns don't always raise interrupts, so check manually */
--
2.25.1
next prev parent reply other threads:[~2025-01-09 20:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 19:45 [PATCH v7 00/14] Display Global Histogram Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 01/14] drm: Define histogram structures exposed to user Arun R Murthy
2025-01-15 19:44 ` Dmitry Baryshkov
2025-01-16 7:08 ` Murthy, Arun R
2025-01-16 7:42 ` Dmitry Baryshkov
2025-01-16 12:33 ` Murthy, Arun R
2025-01-16 13:12 ` Dmitry Baryshkov
2025-01-16 13:33 ` Murthy, Arun R
2025-01-16 13:39 ` Dmitry Baryshkov
2025-01-17 5:50 ` Murthy, Arun R
2025-01-21 6:37 ` Murthy, Arun R
2025-01-09 19:45 ` [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT " Arun R Murthy
2025-01-15 19:55 ` Dmitry Baryshkov
2025-01-16 7:08 ` Murthy, Arun R
2025-01-16 7:26 ` Dmitry Baryshkov
2025-01-16 12:33 ` Murthy, Arun R
2025-01-16 13:12 ` Dmitry Baryshkov
2025-01-16 13:33 ` Murthy, Arun R
2025-01-09 19:45 ` [PATCH v7 03/14] drm/crtc: Expose API to create drm crtc property for histogram Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 04/14] drm/crtc: Expose API to create drm crtc property for IET LUT Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 05/14] drm/i915/histogram: Define registers for histogram Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 06/14] drm/i915/histogram: Add support " Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 07/14] drm/xe: Add histogram support to Xe builds Arun R Murthy
2025-01-16 1:37 ` Dmitry Baryshkov
2025-01-16 7:08 ` Murthy, Arun R
2025-01-16 7:14 ` Dmitry Baryshkov
2025-01-09 19:45 ` [PATCH v7 08/14] drm/i915/histogram: histogram interrupt handling Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 09/14] drm/i915/histogram: Hook i915 histogram with drm histogram Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 10/14] drm/i915/iet: Add support to writing the IET LUT data Arun R Murthy
2025-01-09 19:45 ` Arun R Murthy [this message]
2025-01-09 19:45 ` [PATCH v7 12/14] drm/i915/histogram: histogram delay counter doesnt reset Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 13/14] drm/i915/histogram: Histogram changes for Display 20+ Arun R Murthy
2025-01-09 19:45 ` [PATCH v7 14/14] drm/i915/histogram: Enable pipe dithering Arun R Murthy
2025-01-10 5:58 ` Kandpal, Suraj
2025-01-09 22:33 ` ✗ CI.Patch_applied: failure for Display Global Histogram (rev8) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110-dpst-v7-11-605cb0271162@intel.com \
--to=arun.r.murthy@intel.com \
--cc="Imported from f20241218-dpst-v7-0-81bfe7d08c2d"@intel.com \
--cc=20240705091333.328322-1-mohammed.thasleem@intel.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox