From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH 0/6] Introduce drm sharpness property
Date: Fri, 10 Jan 2025 12:02:38 +0530 [thread overview]
Message-ID: <20250110063244.1129552-1-nemesa.garg@intel.com> (raw)
Many a times images are blurred or upscaled content is also not as
crisp as original rendered image. Traditional sharpening techniques often
apply a uniform level of enhancement across entire image, which sometimes
result in over-sharpening of some areas and potential loss of natural details.
Intel has come up with Display Engine based adaptive sharpening filter
with minimal power and performance impact. From LNL onwards, the Display
hardware can use one of the pipe scaler for adaptive sharpness filter.
This can be used for both gaming and non-gaming use cases like photos,
image viewing. It works on a region of pixels depending on the tap size.
This is an attempt to introduce an adaptive sharpness solution which
helps in improving the image quality. For this new CRTC property is added.
The user can set this property with desired sharpness strength value with
0-255. A value of 1 representing minimum sharpening strength and 255
representing maximum sharpness strength. A strength value of 0 means no
sharpening or sharpening feature disabled.
It works on a region of pixels depending on the tap size. The coefficients
are used to generate an alpha value which is used to blend the sharpened
image to original image.
Middleware MR link: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3665
IGT patchwork link: https://patchwork.freedesktop.org/series/130218/
Continuing discussions from: https://patchwork.freedesktop.org/series/129888/
Nemesa Garg (6):
drm: Introduce sharpness strength property
drm/i915/display: Compute the scaler filter coefficients
drm/i915/display: Configure the scaler
drm/i915/display: Enable the second scaler for sharpness
drm/i915/display: Add registers and compute the strength
drm/i915/display: Load the lut values and enable sharpness
drivers/gpu/drm/drm_atomic_uapi.c | 4 +
drivers/gpu/drm/drm_crtc.c | 35 +++
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_casf.c | 259 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_casf.h | 24 ++
.../gpu/drm/i915/display/intel_casf_regs.h | 39 +++
drivers/gpu/drm/i915/display/intel_crtc.c | 3 +
drivers/gpu/drm/i915/display/intel_display.c | 19 +-
.../drm/i915/display/intel_display_types.h | 16 ++
drivers/gpu/drm/i915/display/intel_pfit.c | 6 +
drivers/gpu/drm/i915/display/skl_scaler.c | 100 ++++++-
drivers/gpu/drm/i915/display/skl_scaler.h | 1 +
drivers/gpu/drm/xe/Makefile | 1 +
include/drm/drm_crtc.h | 17 ++
14 files changed, 508 insertions(+), 17 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_casf.c
create mode 100644 drivers/gpu/drm/i915/display/intel_casf.h
create mode 100644 drivers/gpu/drm/i915/display/intel_casf_regs.h
--
2.25.1
next reply other threads:[~2025-01-10 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 6:32 Nemesa Garg [this message]
2025-01-10 6:32 ` [PATCH 1/6] drm: Introduce sharpness strength property Nemesa Garg
2025-01-10 6:32 ` [PATCH v6 2/6] drm/i915/display: Compute the scaler filter coefficients Nemesa Garg
2025-01-10 6:32 ` [PATCH 3/6] drm/i915/display: Configure the scaler Nemesa Garg
2025-01-10 6:32 ` [PATCH v7 4/6] drm/i915/display: Enable the second scaler for sharpness Nemesa Garg
2025-01-10 6:32 ` [PATCH v6 5/6] drm/i915/display: Add registers and compute the strength Nemesa Garg
2025-01-10 6:32 ` [PATCH 6/6] drm/i915/display: Load the lut values and enable sharpness Nemesa Garg
2025-01-10 7:18 ` ✗ CI.Patch_applied: failure for Introduce drm sharpness property (rev4) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-01-13 10:49 [PATCH 0/6] Introduce drm sharpness property Nemesa Garg
2025-02-14 15:11 Nemesa Garg
2025-02-19 11:53 Nemesa Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110063244.1129552-1-nemesa.garg@intel.com \
--to=nemesa.garg@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox