From: Riana Tauro <riana.tauro@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: riana.tauro@intel.com, anshuman.gupta@intel.com,
rodrigo.vivi@intel.com, aravind.iddamsetty@intel.com,
jani.nikula@linux.intel.com, alexander.usyskin@intel.com
Subject: [PATCH v3 2/3] drm/xe: Enable Boot Survivability mode
Date: Mon, 20 Jan 2025 12:10:41 +0530 [thread overview]
Message-ID: <20250120064042.2596178-3-riana.tauro@intel.com> (raw)
In-Reply-To: <20250120064042.2596178-1-riana.tauro@intel.com>
Enable boot survivability mode if pcode initialization fails and
if boot status indicates a failure. In this mode, drm card is not
exposed and driver probe returns success after loading the bare minimum
to allow firmware to be flashed via mei.
v2: abstract survivability mode variable
add BMG check inside function (Jani, Rodrigo)
v3: return -EBUSY during system suspend (Anshuman)
check survivability mode in pci probe only
on error
Signed-off-by: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 7 ++++++-
drivers/gpu/drm/xe/xe_pci.c | 23 ++++++++++++++++++++--
drivers/gpu/drm/xe/xe_survivability_mode.c | 16 +++++++++++++++
drivers/gpu/drm/xe/xe_survivability_mode.h | 1 +
4 files changed, 44 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 731f9213780c..ca51ff91ee07 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -51,6 +51,7 @@
#include "xe_pm.h"
#include "xe_query.h"
#include "xe_sriov.h"
+#include "xe_survivability_mode.h"
#include "xe_tile.h"
#include "xe_ttm_stolen_mgr.h"
#include "xe_ttm_sys_mgr.h"
@@ -587,8 +588,12 @@ int xe_device_probe_early(struct xe_device *xe)
update_device_info(xe);
err = xe_pcode_probe_early(xe);
- if (err)
+ if (err) {
+ if (xe_survivability_mode_required(xe))
+ xe_survivability_mode_init(xe);
+
return err;
+ }
err = wait_for_lmem_ready(xe);
if (err)
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 7d146e3e8e21..b9a1eb423a33 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -30,6 +30,7 @@
#include "xe_pm.h"
#include "xe_sriov.h"
#include "xe_step.h"
+#include "xe_survivability_mode.h"
#include "xe_tile.h"
enum toggle_d3cold {
@@ -768,6 +769,9 @@ static void xe_pci_remove(struct pci_dev *pdev)
if (IS_SRIOV_PF(xe))
xe_pci_sriov_configure(pdev, 0);
+ if (xe_survivability_mode_enabled(xe))
+ return xe_survivability_mode_remove(xe);
+
xe_device_remove(xe);
xe_pm_runtime_fini(xe);
pci_set_drvdata(pdev, NULL);
@@ -840,8 +844,19 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return err;
err = xe_device_probe_early(xe);
- if (err)
+
+ /*
+ * In Boot Survivability mode, no drm card is exposed
+ * and driver is loaded with bare minimum to allow
+ * for firmware to be flashed through mei. Return
+ * success if survivability mode is enabled.
+ */
+ if (err) {
+ if (xe_survivability_mode_enabled(xe))
+ return 0;
+
return err;
+ }
err = xe_info_init(xe, desc->graphics, desc->media);
if (err)
@@ -928,9 +943,13 @@ static void d3cold_toggle(struct pci_dev *pdev, enum toggle_d3cold toggle)
static int xe_pci_suspend(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
+ struct xe_device *xe = pdev_to_xe_device(pdev);
int err;
- err = xe_pm_suspend(pdev_to_xe_device(pdev));
+ if (xe_survivability_mode_enabled(xe))
+ return -EBUSY;
+
+ err = xe_pm_suspend(xe);
if (err)
return err;
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index b27757b4ef5d..e1ce14d8dec2 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -144,6 +144,19 @@ static void enable_survivability_mode(struct pci_dev *pdev)
}
}
+/**
+ * xe_survivability_mode_enabled - check if survivability mode is enabled
+ * @xe: xe device instance
+ *
+ * Returns true if in survivability mode, false otherwise
+ */
+bool xe_survivability_mode_enabled(struct xe_device *xe)
+{
+ struct xe_survivability *survivability = &xe->survivability;
+
+ return survivability->mode;
+}
+
/**
* xe_survivability_mode_required- checks if survivability mode is required
* @xe: xe device instance
@@ -158,6 +171,9 @@ bool xe_survivability_mode_required(struct xe_device *xe)
struct xe_mmio *mmio = xe_root_tile_mmio(xe);
u32 data;
+ if (!IS_DGFX(xe) || xe->info.platform < XE_BATTLEMAGE)
+ return false;
+
data = xe_mmio_read32(mmio, PCODE_SCRATCH_ADDR(0));
survivability->boot_status = REG_FIELD_GET(BOOT_STATUS, data);
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.h b/drivers/gpu/drm/xe/xe_survivability_mode.h
index 410e3ee5f5d1..f530507a22c6 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.h
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.h
@@ -12,6 +12,7 @@ struct xe_device;
void xe_survivability_mode_init(struct xe_device *xe);
void xe_survivability_mode_remove(struct xe_device *xe);
+bool xe_survivability_mode_enabled(struct xe_device *xe);
bool xe_survivability_mode_required(struct xe_device *xe);
#endif /* _XE_SURVIVABILITY_MODE_H_ */
--
2.47.1
next prev parent reply other threads:[~2025-01-20 6:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 6:40 [PATCH v3 0/3] Enable Survivability mode Riana Tauro
2025-01-20 6:40 ` [PATCH v3 1/3] drm/xe: Add functions and sysfs for boot survivability Riana Tauro
2025-01-21 14:50 ` Rodrigo Vivi
2025-01-20 6:40 ` Riana Tauro [this message]
2025-01-20 6:40 ` [PATCH v3 3/3] drm/xe: Initialize mei-gsc and vsec in survivability mode Riana Tauro
2025-01-22 6:33 ` Usyskin, Alexander
2025-01-20 9:15 ` ✓ CI.Patch_applied: success for Enable Survivability mode (rev3) Patchwork
2025-01-20 9:16 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-20 9:17 ` ✓ CI.KUnit: success " Patchwork
2025-01-20 9:33 ` ✓ CI.Build: " Patchwork
2025-01-20 9:35 ` ✓ CI.Hooks: " Patchwork
2025-01-20 9:37 ` ✓ CI.checksparse: " Patchwork
2025-01-21 8:30 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120064042.2596178-3-riana.tauro@intel.com \
--to=riana.tauro@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox