From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH] drm/xe/guc: Fix sizeof(32) typo
Date: Tue, 21 Jan 2025 10:48:32 +0100 [thread overview]
Message-ID: <20250121094832.588-1-michal.wajdeczko@intel.com> (raw)
A small typo leads to the following static code checker warning:
drivers/gpu/drm/xe/xe_guc_buf.c:81 xe_guc_buf_reserve()
warn: sizeof(NUMBER)?
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-xe/0d5bcbf1-79f9-4a10-a221-ddbaec9f6122@stanley.mountain/
Fixes: 696bfdf273ea ("drm/xe/guc: Introduce the GuC Buffer Cache")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_buf.c b/drivers/gpu/drm/xe/xe_guc_buf.c
index ce6d9830e13b..0193c94dd6a0 100644
--- a/drivers/gpu/drm/xe/xe_guc_buf.c
+++ b/drivers/gpu/drm/xe/xe_guc_buf.c
@@ -78,7 +78,7 @@ struct xe_guc_buf xe_guc_buf_reserve(struct xe_guc_buf_cache *cache, u32 dwords)
struct drm_suballoc *sa;
if (cache->sam)
- sa = __xe_sa_bo_new(cache->sam, dwords * sizeof(32), GFP_ATOMIC);
+ sa = __xe_sa_bo_new(cache->sam, dwords * sizeof(u32), GFP_ATOMIC);
else
sa = ERR_PTR(-EOPNOTSUPP);
--
2.47.1
next reply other threads:[~2025-01-21 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 9:48 Michal Wajdeczko [this message]
2025-01-21 11:54 ` ✓ CI.Patch_applied: success for drm/xe/guc: Fix sizeof(32) typo Patchwork
2025-01-21 11:55 ` ✓ CI.checkpatch: " Patchwork
2025-01-21 11:56 ` ✓ CI.KUnit: " Patchwork
2025-01-21 12:12 ` ✓ CI.Build: " Patchwork
2025-01-21 12:14 ` ✓ CI.Hooks: " Patchwork
2025-01-21 12:16 ` ✓ CI.checksparse: " Patchwork
2025-01-21 12:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-21 16:51 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 20:45 ` Michal Wajdeczko
2025-01-21 17:39 ` [PATCH] " Summers, Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121094832.588-1-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox