Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>, Ilia Levi <ilia.levi@intel.com>
Subject: [PATCH 2/3] drm/xe: Defer irq init until after xe_display_init_noaccel
Date: Tue, 21 Jan 2025 15:28:49 +0100	[thread overview]
Message-ID: <20250121142850.4960-2-dev@lankhorst.se> (raw)
In-Reply-To: <20250121142850.4960-1-dev@lankhorst.se>

As stated in previous commit, we have to move interrupt handling
until after xe_display_init_noaccel, as using memirqs would require
an allocation.

A full solution will of course require memirq allocation to be moved,
but the first part only focuses on the required changes to display.

Reviewed-by: Ilia Levi <ilia.levi@intel.com>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index bd6191e1ed3e7..2e008528a9f92 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -808,10 +808,6 @@ int xe_device_probe(struct xe_device *xe)
 	if (err)
 		return err;
 
-	err = xe_irq_install(xe);
-	if (err)
-		goto err;
-
 	err = probe_has_flat_ccs(xe);
 	if (err)
 		goto err;
@@ -845,6 +841,10 @@ int xe_device_probe(struct xe_device *xe)
 			goto err;
 	}
 
+	err = xe_irq_install(xe);
+	if (err)
+		goto err;
+
 	for_each_gt(gt, xe, id) {
 		last_gt = id;
 
-- 
2.43.0


  reply	other threads:[~2025-01-21 14:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 14:28 [PATCH 1/3] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2025-01-21 14:28 ` Maarten Lankhorst [this message]
2025-01-21 14:28 ` [PATCH 3/3] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2025-01-21 17:57 ` ✓ CI.Patch_applied: success for series starting with [1/3] drm/xe/display: Add intel_plane_initial_vblank_wait Patchwork
2025-01-21 17:58 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-21 17:59 ` ✓ CI.KUnit: success " Patchwork
2025-01-21 18:16 ` ✓ CI.Build: " Patchwork
2025-01-21 18:18 ` ✓ CI.Hooks: " Patchwork
2025-01-21 18:19 ` ✓ CI.checksparse: " Patchwork
2025-01-21 18:46 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-22  0:48 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-28 22:08 ` [PATCH 1/3] " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121142850.4960-2-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=ilia.levi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox