Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH 2/2] drm/xe/oa: Fix locking for stream->pollin
Date: Tue, 21 Jan 2025 10:03:54 -0800	[thread overview]
Message-ID: <20250121180354.3221570-3-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250121180354.3221570-1-ashutosh.dixit@intel.com>

Previously locking was not implemented for stream->pollin. Now
stream->pollin should be accessed under stream->oa_buffer.ptr_lock.

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 drivers/gpu/drm/xe/xe_oa.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index fa873f3d0a9d1..9de62ce4b9e42 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -530,6 +530,7 @@ static ssize_t xe_oa_read(struct file *file, char __user *buf,
 			  size_t count, loff_t *ppos)
 {
 	struct xe_oa_stream *stream = file->private_data;
+	unsigned long flags;
 	size_t offset = 0;
 	int ret;
 
@@ -562,8 +563,10 @@ static ssize_t xe_oa_read(struct file *file, char __user *buf,
 	 * Also in case of -EIO, we have already waited for data before returning
 	 * -EIO, so need to wait again
 	 */
+	spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags);
 	if (ret != -ENOSPC && ret != -EIO)
 		stream->pollin = false;
+	spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
 
 	/* Possible values for ret are 0, -EFAULT, -ENOSPC, -EIO, -EINVAL, ... */
 	return offset ?: (ret ?: -EAGAIN);
@@ -573,6 +576,7 @@ static __poll_t xe_oa_poll_locked(struct xe_oa_stream *stream,
 				  struct file *file, poll_table *wait)
 {
 	__poll_t events = 0;
+	unsigned long flags;
 
 	poll_wait(file, &stream->poll_wq, wait);
 
@@ -582,8 +586,10 @@ static __poll_t xe_oa_poll_locked(struct xe_oa_stream *stream,
 	 * in use. We rely on hrtimer xe_oa_poll_check_timer_cb to notify us when there
 	 * are samples to read
 	 */
+	spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags);
 	if (stream->pollin)
 		events |= EPOLLIN;
+	spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
 
 	return events;
 }
-- 
2.47.1


  parent reply	other threads:[~2025-01-21 18:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 18:03 [PATCH 0/2] stream->pollin fixes Ashutosh Dixit
2025-01-21 18:03 ` [PATCH 1/2] drm/xe/oa: Set stream->pollin in xe_oa_buffer_check_unlocked Ashutosh Dixit
2025-01-21 18:03 ` Ashutosh Dixit [this message]
2025-01-21 23:19   ` [PATCH 2/2] drm/xe/oa: Fix locking for stream->pollin Rodrigo Vivi
2025-01-22  4:04     ` Dixit, Ashutosh
2025-01-21 19:54 ` ✓ CI.Patch_applied: success for stream->pollin fixes Patchwork
2025-01-21 19:54 ` ✓ CI.checkpatch: " Patchwork
2025-01-21 19:55 ` ✓ CI.KUnit: " Patchwork
2025-01-21 20:12 ` ✓ CI.Build: " Patchwork
2025-01-21 20:15 ` ✓ CI.Hooks: " Patchwork
2025-01-21 20:16 ` ✓ CI.checksparse: " Patchwork
2025-01-21 20:43 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-22  3:37 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121180354.3221570-3-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox