Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Maarten Lankhort <maarten.lankhorst@linux.intel.com>,
	Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: [PATCH 2/3] drm/xe: At shutdown disable commit helpers instead of flushing
Date: Wed, 22 Jan 2025 05:40:48 -0500	[thread overview]
Message-ID: <20250122104049.388340-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20250122104049.388340-1-rodrigo.vivi@intel.com>

This aligns with the current i915 display sequence.

Cc: Maarten Lankhort <maarten.lankhorst@linux.intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 96ba9595bf2a..4f60d7bd7742 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -10,6 +10,7 @@
 
 #include <drm/drm_drv.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <uapi/drm/xe_drm.h>
 
@@ -378,10 +379,10 @@ void xe_display_pm_shutdown(struct xe_device *xe)
 	if (has_display(xe)) {
 		drm_kms_helper_poll_disable(&xe->drm);
 		intel_display_driver_disable_user_access(display);
-		intel_display_driver_suspend(display);
+
+		drm_atomic_helper_shutdown(display->drm);
 	}
 
-	xe_display_flush_cleanup_work(xe);
 	intel_dp_mst_suspend(display);
 	intel_hpd_cancel_work(xe);
 
-- 
2.48.1


  reply	other threads:[~2025-01-22 10:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 10:40 [PATCH 1/3] drm/i915/display: Move shutdown sequences under display driver Rodrigo Vivi
2025-01-22 10:40 ` Rodrigo Vivi [this message]
2025-01-22 10:40 ` [PATCH 3/3] drm/xe: Use i915-display shutdown sequence directly Rodrigo Vivi
2025-01-22 12:33 ` ✓ CI.Patch_applied: success for series starting with [1/3] drm/i915/display: Move shutdown sequences under display driver Patchwork
2025-01-22 12:34 ` ✓ CI.checkpatch: " Patchwork
2025-01-22 12:35 ` ✓ CI.KUnit: " Patchwork
2025-01-22 12:51 ` ✓ CI.Build: " Patchwork
2025-01-22 12:53 ` ✓ CI.Hooks: " Patchwork
2025-01-22 12:55 ` ✓ CI.checksparse: " Patchwork
2025-01-22 13:22 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-23  0:33 ` ✗ Xe.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-01-17 22:09 [PATCH 1/3] " Rodrigo Vivi
2025-01-17 22:09 ` [PATCH 2/3] drm/xe: At shutdown disable commit helpers instead of flushing Rodrigo Vivi
2024-11-14 20:22 [PATCH 1/3] drm/i915/display: Move shutdown sequences under display driver Rodrigo Vivi
2024-11-14 20:22 ` [PATCH 2/3] drm/xe: At shutdown disable commit helpers instead of flushing Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122104049.388340-2-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox