From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E11A9C0218D for ; Wed, 29 Jan 2025 04:37:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A0F510E220; Wed, 29 Jan 2025 04:37:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linux.org.uk header.i=@linux.org.uk header.b="MlUf2rJ3"; dkim-atps=neutral Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2816F10E220; Wed, 29 Jan 2025 04:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JeX1tJAMrqtvR3jMf2b/sXaEH55G0StnWi48rc5YjKQ=; b=MlUf2rJ3uR4N5+mmtmJhhLS3DQ RG+fqLhuTpSM0fsEz2aO/Ta9PawFZxxAsxThE+6kLou0Ug3Ha2fLYHZnua8PcLrlYhbxo6TVmtSOI bzwXsJKwCUZybuP/cqZ2rGBsh+MPTdI5cz+n1qIhuvi31K0s/fJjDyfcYojq/XHEwaXXsNI52U+Cz cwPFlvMwCxMj/dar3EreUPVWeDm7jlVusk0PFj5BZEdEKi9/lrlEFj/jYNQBYt8GWGujfNrzfVBsx 0vCuQaP//LyvHJNcLBp60DOSubMBo3m7eyOpiqiD/MeOx9g6lQYM5PiVigRhhCpbv9uioucLaVcDL B7d75YGA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tczpA-0000000EzFI-0DpE; Wed, 29 Jan 2025 04:37:12 +0000 Date: Wed, 29 Jan 2025 04:37:12 +0000 From: Al Viro To: "Borah, Chaitanya Kumar" Cc: Greg Kroah-Hartman , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "Kurmi, Suresh Kumar" , "Saarinen, Jani" , "linux-fsdevel@vger.kernel.org" , Alexander Gordeev Subject: Re: Regression on linux-next (next-20250120) Message-ID: <20250129043712.GQ1977892@ZenIV> References: <20250123181853.GC1977892@ZenIV> <20250127050416.GE1977892@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, Jan 28, 2025 at 04:00:58PM +0000, Borah, Chaitanya Kumar wrote: > Unfortunately this change does not help us. I think it is the methods member that causes the problem. So the following change solves the problem for us. > > > --- a/fs/debugfs/file.c > +++ b/fs/debugfs/file.c > @@ -102,6 +102,8 @@ static int __debugfs_file_get(struct dentry *dentry, enum dbgfs_get_mode mode) > if (!fsd) > return -ENOMEM; > > + fsd->methods = 0; > + > if (mode == DBGFS_GET_SHORT) { > const struct debugfs_short_fops *ops; > ops = fsd->short_fops = DEBUGFS_I(inode)->short_fops; D'OH. Both are needed, actually. Slightly longer term I would rather split full_proxy_{read,write,lseek}() into short and full variant, getting rid of the "check which pointer is non-NULL" and killed the two remaining users of debugfs_real_fops() outside of fs/debugfs/file.c; then we could union these ->..._fops pointers, but until then they need to be initialized. And yes, ->methods obviously needs to be initialized. Al, bloody embarrassed ;-/