From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E520EC02190 for ; Thu, 30 Jan 2025 10:14:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A80A310E928; Thu, 30 Jan 2025 10:14:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JmZr8yxl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A02A10E92B for ; Thu, 30 Jan 2025 10:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738232045; x=1769768045; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ThFNrYXVitCZGlEDNTVkigQQdsT3hD63kNWa8M7ESkc=; b=JmZr8yxlswJMWuuG80S1TkQsOGSCzd+gnYpV6W+x2CnU8iCIrjpFWHov R0dCGekESY/vbhjmKBJbSNVoTrGtHjkUCV3q5sBx66q0D98MkSctQsrwM fEa4wa2aA+D8iZdtrp8V0uctlO+TCgt/GoddyNhxveVfUpxHRo+iyM+N2 KvYUAsRB2DZNf4tP3y2MWy8+X7EqdUG5E5VcLbtU8TdfQKu/lxhQLR9NQ VS2NkVjVbaZbebW2fenTEh9DLleNdYaIsGlfpuAxivkTTCf3WcZy2DE+C 9MCP2np03ZkyV2RSGMygLMuhy+ruxbSzI8ruqBs0a14q1NAie5WlKe5yM w==; X-CSE-ConnectionGUID: n4uQxy59Qw+Xv65t66l0xQ== X-CSE-MsgGUID: Z9oSbmYSRdOafIgfvFCvZg== X-IronPort-AV: E=McAfee;i="6700,10204,11330"; a="39036606" X-IronPort-AV: E=Sophos;i="6.13,245,1732608000"; d="scan'208";a="39036606" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 02:14:04 -0800 X-CSE-ConnectionGUID: s9KAF6wBTP+sr/OSlvRHgw== X-CSE-MsgGUID: SwFE0saGTHqlvzE10ehU5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="140163526" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO fedora..) ([10.245.246.79]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 02:14:03 -0800 From: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= To: intel-xe@lists.freedesktop.org Cc: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost Subject: [PATCH v16 7/7] drm/xe: Increase the XE_PL_TT watermark Date: Thu, 30 Jan 2025 11:13:25 +0100 Message-ID: <20250130101325.3068-8-thomas.hellstrom@linux.intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250130101325.3068-1-thomas.hellstrom@linux.intel.com> References: <20250130101325.3068-1-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memory. The TTM functionality that tries to swap out system memory to shmem objects if a 50% limit of total system memory is reached is orthogonal to this, and with the shrinker added, it's no longer in effect. Replace the 50% TTM_PL_TT limit with a 100% limit, in effect allowing all graphics memory to be bound to the device unless it has been swapped out by the shrinker. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c index 9844a8edbfe1..d38b91872da3 100644 --- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c @@ -108,9 +108,8 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe) u64 gtt_size; si_meminfo(&si); + /* Potentially restrict amount of TT memory here. */ gtt_size = (u64)si.totalram * si.mem_unit; - /* TTM limits allocation of all TTM devices by 50% of system memory */ - gtt_size /= 2; man->use_tt = true; man->func = &xe_ttm_sys_mgr_func; -- 2.48.1