From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5250C02194 for ; Thu, 6 Feb 2025 01:56:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BDEB10E0A4; Thu, 6 Feb 2025 01:56:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QWOfZOs3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id C7E9410E1FF for ; Thu, 6 Feb 2025 01:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738806974; x=1770342974; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2Omjh+n1oKKgVkA/mfb2uLbE4Ir9N+Q1vrqUMQQm+kQ=; b=QWOfZOs3dNbD+ZUAxOwvi2QWdhpLYEwmZrWVQBEPw0HEjiyqV0GxDy4L n0BA5nvXZRuqaZfkRMYWSnBwl02o4wWgSh64CiTxV1nasWTMj50d0x/6O 9YrQanT/Ou5q0KBEVNGfizvdtZLgVIFN0o+TDrxQIW584BD0BVBwvBy8G VKjJYZSQUNtxD3Z2lhCK3TFyS1UsqFrXlyoFOolOYEIwt7XyZjtilJArF 8YTw15G0VMV4STjeeALfusZ+ZsQV4Kq3mVDTe5osDA+Kai2xhOK70Xwks uZOAbftfV8BakPEJ0JueLTMQvxnNlyjI60xHC8gQ5snRGf8U1XNU+g/zB w==; X-CSE-ConnectionGUID: LcUMRFM6StSPmPDWe1DuLg== X-CSE-MsgGUID: 55Wuv2t+TXyCbeB8Rgbqkw== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="50382570" X-IronPort-AV: E=Sophos;i="6.13,263,1732608000"; d="scan'208";a="50382570" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2025 17:56:14 -0800 X-CSE-ConnectionGUID: sEwmv9A6Tq+XE4gM1AOomw== X-CSE-MsgGUID: p6iyPf9FSqOQwDEYR9nRSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,263,1732608000"; d="scan'208";a="111655193" Received: from szeng-desk.jf.intel.com ([10.165.21.160]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2025 17:56:03 -0800 From: Oak Zeng To: intel-xe@lists.freedesktop.org Cc: Thomas.Hellstrom@linux.intel.com, matthew.brost@intel.com, jonathan.cavitt@intel.com Subject: [PATCH 1/3] drm/xe: Introduced needs_scratch bit in device descriptor Date: Wed, 5 Feb 2025 21:11:24 -0500 Message-Id: <20250206021126.3420-1-oak.zeng@intel.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On some platform, scratch page is needed for out of bound prefetch to work. Introduce a bit in device descriptor to specify whether this device needs scratch page to work. v2: introduce a needs_scratch bit in device info (Thomas, Jonathan) Signed-off-by: Oak Zeng Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_device_types.h | 3 +++ drivers/gpu/drm/xe/xe_pci.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h index c0e886bac183..1197ab31e528 100644 --- a/drivers/gpu/drm/xe/xe_device_types.h +++ b/drivers/gpu/drm/xe/xe_device_types.h @@ -45,6 +45,7 @@ struct xe_pxp; #define GRAPHICS_VERx100(xe) ((xe)->info.graphics_verx100) #define MEDIA_VERx100(xe) ((xe)->info.media_verx100) #define IS_DGFX(xe) ((xe)->info.is_dgfx) +#define NEEDS_SCRATCH(xe) ((xe)->info.needs_scratch) #define XE_VRAM_FLAGS_NEED64K BIT(0) @@ -318,6 +319,8 @@ struct xe_device { u8 has_usm:1; /** @info.is_dgfx: is discrete device */ u8 is_dgfx:1; + /** @info.needs_scratch: needs scratch page for oob prefetch to work */ + u8 needs_scratch:1; /** * @info.probe_display: Probe display hardware. If set to * false, the driver will behave as if there is no display diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index e8ef7d6b4db8..09736674a77e 100644 --- a/drivers/gpu/drm/xe/xe_pci.c +++ b/drivers/gpu/drm/xe/xe_pci.c @@ -67,6 +67,7 @@ struct xe_device_desc { u8 has_llc:1; u8 has_pxp:1; u8 has_sriov:1; + u8 needs_scratch:1; u8 skip_guc_pc:1; u8 skip_mtcfg:1; u8 skip_pcode:1; @@ -353,6 +354,7 @@ static const struct xe_device_desc lnl_desc = { .dma_mask_size = 46, .has_display = true, .has_pxp = true, + .needs_scratch = true, }; static const struct xe_device_desc bmg_desc = { @@ -361,6 +363,7 @@ static const struct xe_device_desc bmg_desc = { .dma_mask_size = 46, .has_display = true, .has_heci_cscfi = 1, + .needs_scratch = true, }; static const struct xe_device_desc ptl_desc = { @@ -368,6 +371,7 @@ static const struct xe_device_desc ptl_desc = { .dma_mask_size = 46, .has_display = true, .require_force_probe = true, + .needs_scratch = true, }; #undef PLATFORM @@ -643,6 +647,7 @@ static int xe_info_init_early(struct xe_device *xe, xe->info.skip_guc_pc = desc->skip_guc_pc; xe->info.skip_mtcfg = desc->skip_mtcfg; xe->info.skip_pcode = desc->skip_pcode; + xe->info.needs_scratch = desc->needs_scratch; xe->info.probe_display = IS_ENABLED(CONFIG_DRM_XE_DISPLAY) && xe_modparam.probe_display && -- 2.26.3