Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 3/3] drm/i915: Replace the HAS_DDI() in intel_crtc_scanline_offset() with specific platform checks
Date: Fri,  7 Feb 2025 23:54:06 +0200	[thread overview]
Message-ID: <20250207215406.19348-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250207215406.19348-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The HDMI vs. not scanline offset stuff no longer applies to the
latest platforms, so using HAS_DDI() is a bit confusing. Replace
with a more specific set of conditions.

Also let's just deal with the platform types in the if ladder
itself, and handle the HDMI vs. not within the specific branch
for those platforms.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vblank.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index dd928d890e3a..139fa5deba80 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -224,8 +224,9 @@ int intel_crtc_scanline_offset(const struct intel_crtc_state *crtc_state)
 	 */
 	if (DISPLAY_VER(display) >= 20 || display->platform.battlemage)
 		return 1;
-	else if (HAS_DDI(display) && intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
-		return 2;
+	else if (DISPLAY_VER(display) >= 9 ||
+		 display->platform.broadwell || display->platform.haswell)
+		return intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI) ? 2 : 1;
 	else if (DISPLAY_VER(display) >= 3)
 		return 1;
 	else
-- 
2.45.3


  parent reply	other threads:[~2025-02-07 21:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 21:54 [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+ Ville Syrjala
2025-02-07 21:54 ` [PATCH 1/3] drm/i915: Fix scanline_offset for LNL+ and BMG+ Ville Syrjala
2025-02-20  9:30   ` Hogander, Jouni
2025-03-20 11:23   ` Shankar, Uma
2025-02-07 21:54 ` [PATCH 2/3] drm/i915: Reverse the scanline_offset if ladder Ville Syrjala
2025-02-20 10:02   ` Hogander, Jouni
2025-02-07 21:54 ` Ville Syrjala [this message]
2025-02-20  9:58   ` [PATCH 3/3] drm/i915: Replace the HAS_DDI() in intel_crtc_scanline_offset() with specific platform checks Hogander, Jouni
2025-02-07 22:36 ` ✓ CI.Patch_applied: success for drm/i915: Fix scanline_offset for LNL+/BMG+ Patchwork
2025-02-07 22:36 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-07 22:37 ` ✓ CI.KUnit: success " Patchwork
2025-02-07 22:41 ` [PATCH 0/3] " Lucas De Marchi
2025-02-10 16:05   ` Gustavo Sousa
2025-02-10 16:16   ` Ville Syrjälä
2025-02-10 18:10     ` Lucas De Marchi
2025-02-10 20:02       ` Ville Syrjälä
2025-02-10 21:49         ` Matt Roper
2025-02-07 22:53 ` ✓ CI.Build: success for " Patchwork
2025-02-07 22:56 ` ✓ CI.Hooks: " Patchwork
2025-02-07 22:57 ` ✓ CI.checksparse: " Patchwork
2025-02-07 23:17 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-08 14:18 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207215406.19348-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox