From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Subject: [PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call
Date: Mon, 10 Feb 2025 16:07:18 -0500 [thread overview]
Message-ID: <20250210210719.477386-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20250210210719.477386-1-rodrigo.vivi@intel.com>
xe_guc_pc_start() was getting called from both
xe_uc_init_hw() and from xe_guc_start().
But both are called from do_gt_restart() and only
xe_uc_init_hw() is called at initialization.
So, let's remove the duplication in the regular gt_restart
path.
The only place where xe_guc_pc_start() won't get called now
is on the gt_reset failure path. However, if gt_reset has
failed, it is really unlikely that the PC start will work
or is desired.
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_guc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 1619c0a52db9..eaa035b25aa8 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -1491,14 +1491,6 @@ void xe_guc_stop(struct xe_guc *guc)
int xe_guc_start(struct xe_guc *guc)
{
- if (!IS_SRIOV_VF(guc_to_xe(guc))) {
- int err;
-
- err = xe_guc_pc_start(&guc->pc);
- xe_gt_WARN(guc_to_gt(guc), err, "Failed to start GuC PC: %pe\n",
- ERR_PTR(err));
- }
-
return xe_guc_submit_start(guc);
}
--
2.48.1
next prev parent reply other threads:[~2025-02-10 21:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 21:07 [PATCH 1/2] drm/xe/guc_pc: Do not stop probe or resume if GuC PC fails Rodrigo Vivi
2025-02-10 21:07 ` Rodrigo Vivi [this message]
2025-02-10 22:04 ` [PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call Cavitt, Jonathan
2025-02-10 22:04 ` [PATCH 1/2] drm/xe/guc_pc: Do not stop probe or resume if GuC PC fails Cavitt, Jonathan
2025-02-11 20:00 ` Rodrigo Vivi
2025-02-10 22:09 ` ✓ CI.Patch_applied: success for series starting with [1/2] " Patchwork
2025-02-10 22:09 ` ✓ CI.checkpatch: " Patchwork
2025-02-10 22:11 ` ✓ CI.KUnit: " Patchwork
2025-02-10 22:27 ` ✓ CI.Build: " Patchwork
2025-02-10 22:29 ` ✗ CI.Hooks: failure " Patchwork
2025-02-10 22:29 ` ✗ CI.checksparse: warning " Patchwork
2025-02-10 22:48 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-11 9:03 ` ✗ Xe.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-02-11 20:09 [PATCH 1/2] " Rodrigo Vivi
2025-02-11 20:09 ` [PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call Rodrigo Vivi
2025-02-14 0:31 ` Belgaumkar, Vinay
2025-02-14 17:25 [PATCH 1/2] drm/xe/guc_pc: Do not stop probe or resume if GuC PC fails Rodrigo Vivi
2025-02-14 17:25 ` [PATCH 2/2] drm/xe/guc_pc: Remove duplicated pc_start call Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210210719.477386-2-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox