From: Arun R Murthy <arun.r.murthy@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com,
Arun R Murthy <arun.r.murthy@intel.com>,
Naveen Kumar <naveen1.kumar@intel.com>
Subject: [PATCH v5 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async
Date: Tue, 18 Feb 2025 14:32:49 +0530 [thread overview]
Message-ID: <20250218-asyn-v5-3-7ac5ac4abd4a@intel.com> (raw)
In-Reply-To: <20250218-asyn-v5-0-7ac5ac4abd4a@intel.com>
Hook up the newly added plane function pointer
format_mod_supported_async to populate the modifiers/formats supported
by asynchronous flips.
v5: Correct the if condition for modifier support check (Chaitanya)
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Tested-by: Naveen Kumar <naveen1.kumar@intel.com>
---
drivers/gpu/drm/i915/display/skl_universal_plane.c | 56 ++++++++++++++++------
1 file changed, 41 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index cd9762947f1de227a3abbcd61b7c7b0c9848e439..e303ae6b1c6208755ea0454ba36efcff0c06cda6 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -509,6 +509,33 @@ skl_plane_max_stride(struct intel_plane *plane,
modifier, rotation,
max_pixels, max_bytes);
}
+static bool intel_plane_async_formats(struct intel_plane *plane, uint32_t format)
+{
+ switch (format) {
+ case DRM_FORMAT_RGB565:
+ case DRM_FORMAT_XRGB8888:
+ case DRM_FORMAT_XBGR8888:
+ case DRM_FORMAT_ARGB8888:
+ case DRM_FORMAT_ABGR8888:
+ case DRM_FORMAT_XRGB2101010:
+ case DRM_FORMAT_XBGR2101010:
+ case DRM_FORMAT_XRGB16161616F:
+ case DRM_FORMAT_XBGR16161616F:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static bool intel_plane_format_mod_supported_async(struct drm_plane *plane,
+ uint32_t format,
+ uint64_t modifier)
+{
+ if (!intel_plane_can_async_flip(to_intel_plane(plane), modifier))
+ return false;
+
+ return intel_plane_async_formats(to_intel_plane(plane), format);
+}
static bool tgl_plane_can_async_flip(u64 modifier)
{
@@ -2616,30 +2643,29 @@ static bool tgl_plane_format_mod_supported(struct drm_plane *_plane,
}
}
+#define INTEL_PLANE_FUNCS \
+ .update_plane = drm_atomic_helper_update_plane, \
+ .disable_plane = drm_atomic_helper_disable_plane, \
+ .destroy = intel_plane_destroy, \
+ .atomic_duplicate_state = intel_plane_duplicate_state, \
+ .atomic_destroy_state = intel_plane_destroy_state, \
+ .format_mod_supported_async = intel_plane_format_mod_supported_async
+
static const struct drm_plane_funcs skl_plane_funcs = {
- .update_plane = drm_atomic_helper_update_plane,
- .disable_plane = drm_atomic_helper_disable_plane,
- .destroy = intel_plane_destroy,
- .atomic_duplicate_state = intel_plane_duplicate_state,
- .atomic_destroy_state = intel_plane_destroy_state,
+ INTEL_PLANE_FUNCS,
+
.format_mod_supported = skl_plane_format_mod_supported,
};
static const struct drm_plane_funcs icl_plane_funcs = {
- .update_plane = drm_atomic_helper_update_plane,
- .disable_plane = drm_atomic_helper_disable_plane,
- .destroy = intel_plane_destroy,
- .atomic_duplicate_state = intel_plane_duplicate_state,
- .atomic_destroy_state = intel_plane_destroy_state,
+ INTEL_PLANE_FUNCS,
+
.format_mod_supported = icl_plane_format_mod_supported,
};
static const struct drm_plane_funcs tgl_plane_funcs = {
- .update_plane = drm_atomic_helper_update_plane,
- .disable_plane = drm_atomic_helper_disable_plane,
- .destroy = intel_plane_destroy,
- .atomic_duplicate_state = intel_plane_duplicate_state,
- .atomic_destroy_state = intel_plane_destroy_state,
+ INTEL_PLANE_FUNCS,
+
.format_mod_supported = tgl_plane_format_mod_supported,
};
--
2.25.1
next prev parent reply other threads:[~2025-02-18 9:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 9:02 [PATCH v5 0/3] Expose modifiers/formats supported by async flips Arun R Murthy
2025-02-18 9:02 ` [PATCH v5 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC Arun R Murthy
2025-02-18 9:02 ` [PATCH v5 2/3] drm/plane: modify create_in_formats to accommodate async Arun R Murthy
2025-02-18 9:02 ` Arun R Murthy [this message]
2025-02-18 11:46 ` [PATCH v5 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async Jani Nikula
2025-02-18 14:50 ` Sebastian Brzezinka
2025-02-18 10:17 ` ✓ CI.Patch_applied: success for Expose modifiers/formats supported by async flips (rev5) Patchwork
2025-02-18 10:17 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-18 10:18 ` ✓ CI.KUnit: success " Patchwork
2025-02-18 10:35 ` ✓ CI.Build: " Patchwork
2025-02-18 10:37 ` ✓ CI.Hooks: " Patchwork
2025-02-18 10:39 ` ✗ CI.checksparse: warning " Patchwork
2025-02-19 7:29 ` ✓ CI.Patch_applied: success for Expose modifiers/formats supported by async flips (rev6) Patchwork
2025-02-19 7:29 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-19 7:30 ` ✓ CI.KUnit: success " Patchwork
2025-02-19 7:47 ` ✓ CI.Build: " Patchwork
2025-02-19 7:49 ` ✓ CI.Hooks: " Patchwork
2025-02-19 7:51 ` ✗ CI.checksparse: warning " Patchwork
2025-02-19 8:10 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-20 4:09 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-20 8:24 ` ✗ Xe.CI.Full: failure for Expose modifiers/formats supported by async flips (rev5) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-02-12 16:18 [PATCH v5 0/3] Expose modifiers/formats supported by async flips Arun R Murthy
2025-02-12 16:18 ` [PATCH v5 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async Arun R Murthy
2025-02-17 5:28 ` Borah, Chaitanya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218-asyn-v5-3-7ac5ac4abd4a@intel.com \
--to=arun.r.murthy@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=naveen1.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox