Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	John Harrison <John.C.Harrison@Intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH v3 1/2] drm/xe/devcoredump: Fix print typo of offset
Date: Thu, 20 Feb 2025 00:17:09 +0000	[thread overview]
Message-ID: <20250220001710.1803749-2-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20250220001710.1803749-1-shuicheng.lin@intel.com>

The log should print with "offset" instead of "size".
Correct the typo in the comment.

v2: split kzalloc change and add typo fix in commit message (Lucas)

Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 39fe485d2085..60d15e455017 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -237,7 +237,7 @@ static void xe_devcoredump_deferred_snap_work(struct work_struct *work)
 
 	/*
 	 * NB: Despite passing a GFP_ flags parameter here, more allocations are done
-	 * internally using GFP_KERNEL expliictly. Hence this call must be in the worker
+	 * internally using GFP_KERNEL explicitly. Hence this call must be in the worker
 	 * thread and not in the initial capture call.
 	 */
 	dev_coredumpm_timeout(gt_to_xe(ss->gt)->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL,
@@ -423,7 +423,7 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix, char suffi
 	if (size & 3)
 		drm_printf(p, "Size not word aligned: %zu", size);
 	if (offset & 3)
-		drm_printf(p, "Offset not word aligned: %zu", size);
+		drm_printf(p, "Offset not word aligned: %zu", offset);
 
 	line_buff = kzalloc(DMESG_MAX_LINE_LEN, GFP_KERNEL);
 	if (IS_ERR_OR_NULL(line_buff)) {
-- 
2.25.1


  reply	other threads:[~2025-02-20  0:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 21:26 [PATCH] drm/xe/devcoredump: Fix print typo of offset Shuicheng Lin
2025-02-19 22:48 ` ✓ CI.Patch_applied: success for drm/xe/devcoredump: Fix print typo of offset (rev2) Patchwork
2025-02-19 22:48 ` ✓ CI.checkpatch: " Patchwork
2025-02-19 22:49 ` ✓ CI.KUnit: " Patchwork
2025-02-19 23:06 ` ✓ CI.Build: " Patchwork
2025-02-19 23:08 ` ✓ CI.Hooks: " Patchwork
2025-02-19 23:10 ` ✓ CI.checksparse: " Patchwork
2025-02-19 23:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-20  0:17 ` [PATCH v3 0/2] drm/xe/devcoredump: Fix print typo of offset Shuicheng Lin
2025-02-20  0:17   ` Shuicheng Lin [this message]
2025-02-20 14:29     ` [PATCH v3 1/2] " Upadhyay, Tejas
2025-02-20  0:17   ` [PATCH v3 2/2] drm/xe/devcoredump: Remove IS_ERR_OR_NULL check for kzalloc Shuicheng Lin
2025-02-20 14:36     ` Upadhyay, Tejas
2025-02-20 16:29     ` Michal Wajdeczko
2025-02-20 23:54       ` Lucas De Marchi
2025-02-21  1:36         ` John Harrison
2025-02-24 21:22           ` Lin, Shuicheng
2025-02-24 21:38           ` Lucas De Marchi
2025-02-24 22:14             ` John Harrison
2025-02-20  0:56 ` ✓ CI.Patch_applied: success for drm/xe/devcoredump: Fix print typo of offset (rev3) Patchwork
2025-02-20  0:57 ` ✓ CI.checkpatch: " Patchwork
2025-02-20  0:58 ` ✓ CI.KUnit: " Patchwork
2025-02-20  1:14 ` ✓ CI.Build: " Patchwork
2025-02-20  1:17 ` ✓ CI.Hooks: " Patchwork
2025-02-20  1:18 ` ✓ CI.checksparse: " Patchwork
2025-02-20  1:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-20 21:31 ` ✗ Xe.CI.Full: failure for drm/xe/devcoredump: Fix print typo of offset (rev2) Patchwork
2025-02-21  0:11 ` ✗ Xe.CI.Full: failure for drm/xe/devcoredump: Fix print typo of offset (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220001710.1803749-2-shuicheng.lin@intel.com \
    --to=shuicheng.lin@intel.com \
    --cc=John.C.Harrison@Intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox