From: Aradhya Bhatia <aradhya.bhatia@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Intel XE List <intel-xe@lists.freedesktop.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Tejas Upadhyay <tejas.upadhyay@intel.com>,
Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>,
Aradhya Bhatia <aradhya.bhatia@intel.com>
Subject: [PATCH v5 0/2] drm/xe: Add and refactor workarounds
Date: Thu, 20 Feb 2025 15:16:43 +0530 [thread overview]
Message-ID: <20250220094645.358647-1-aradhya.bhatia@intel.com> (raw)
Hello,
This patch series adds the workarounds, Wa_16021333562, and Wa_14016712196.
It further refactors Wa_18013179988, Wa_14015568240, Wa_1508761755, and
Wa_1509372804, to use the newer macro, XE_WA(), for OOB workarounds,
instead of selection based on platform labels.
Thanks,
Aradhya
---
Change Log:
V5:
- Rename LRC_PPHWSP_SCRATCH_ADDR to LRC_PPHWSP_FLUSH_INVAL_SCRATCH_ADDR
in the WA implementation, as the name has gotten updated in commit
f0c06677d110 ("drm/xe/pxp: Add VCS inline termination support"), in
patch 1/2, as reported by Lucas De Marchi.
- Move the Wa_14016712196 diff chunk above all the flags and calculations
for better clarity in patch-1/2, as recommended by Lucas De Marchi.
- Add R-b tags of Tejas Upadhyay in patch-1, and Lucas De Marchi in
patch-2.
V4:
- Combine Wa_16021333562 condition check with another workaround in
patch-1, as suggested by Tejas Upadhyay.
- Fix the offset value for the pipe control emit for Wa_14016712196 in
patch-1, as suggested by Tejas Upadhyay.
- Add Tejas Upadhyay's R-b tag for patch-2.
V3:
- Fix the applicable Gfx platform ranges for WAs, in patches 1, and 2.
- Add more WAs for refactoring in patch-2, and reword it accordingly.
V2:
- Add new patch (patch-2/2) which involves refactoring the WA
implementation as suggested by Lucas De Marchi.
- Expand the ranges of Wa_16021333562 and Wa_14016712196 as per WA
database, in patch-1/2, and in that process add the WAs properly
instead of porting them for a select few platforms.
- Reword the commit subject and commit text in patch-1 accordingly.
Previous Revisions:
V1: https://lore.kernel.org/all/20250115080048.2282183-1-aradhya.bhatia@intel.com/
V2: https://lore.kernel.org/all/20250116091004.3060996-1-aradhya.bhatia@intel.com/
V3: https://lore.kernel.org/all/20250120060916.778406-1-aradhya.bhatia@intel.com/
V4: https://lore.kernel.org/all/20250130055939.282988-1-aradhya.bhatia@intel.com/
Aradhya Bhatia (2):
drm/xe: Add Wa_16021333562 and Wa_14016712196
drm/xe/oa: Refactor WAs to use XE_WA() macro
drivers/gpu/drm/xe/xe_guc_ads.c | 2 +-
drivers/gpu/drm/xe/xe_oa.c | 30 +++++++++---------------------
drivers/gpu/drm/xe/xe_ring_ops.c | 4 ++++
drivers/gpu/drm/xe/xe_wa_oob.rules | 9 +++++++++
4 files changed, 23 insertions(+), 22 deletions(-)
base-commit: a1e5b6d83e03d60d15ba393cbbd7d5c13e5cf0b3
--
2.34.1
next reply other threads:[~2025-02-20 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:46 Aradhya Bhatia [this message]
2025-02-20 9:46 ` [PATCH v5 1/2] drm/xe: Add Wa_16021333562 and Wa_14016712196 Aradhya Bhatia
2025-02-20 9:46 ` [PATCH v5 2/2] drm/xe/oa: Refactor WAs to use XE_WA() macro Aradhya Bhatia
2025-02-20 9:52 ` ✓ CI.Patch_applied: success for drm/xe: Add and refactor workarounds (rev4) Patchwork
2025-02-20 9:52 ` ✓ CI.checkpatch: " Patchwork
2025-02-20 9:53 ` ✓ CI.KUnit: " Patchwork
2025-02-20 10:10 ` ✓ CI.Build: " Patchwork
2025-02-20 10:12 ` ✓ CI.Hooks: " Patchwork
2025-02-20 10:14 ` ✓ CI.checksparse: " Patchwork
2025-02-20 10:34 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-21 4:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-26 16:54 ` [PATCH v5 0/2] drm/xe: Add and refactor workarounds Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220094645.358647-1-aradhya.bhatia@intel.com \
--to=aradhya.bhatia@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox