From: Matt Roper <matthew.d.roper@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v2 3/5] drm/xe/kunit: Export xe_step_name for KUNIT
Date: Mon, 24 Feb 2025 14:45:47 -0800 [thread overview]
Message-ID: <20250224224547.GC4460@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20250224150700.1778-4-michal.wajdeczko@intel.com>
On Mon, Feb 24, 2025 at 04:06:58PM +0100, Michal Wajdeczko wrote:
> We use xe_step_name() inside the xe_assert() that in turn could
> be used in our kunit test modules so it must be exported.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/xe/xe_step.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_step.c b/drivers/gpu/drm/xe/xe_step.c
> index c77b5c317fa0..db600cc9c5f2 100644
> --- a/drivers/gpu/drm/xe/xe_step.c
> +++ b/drivers/gpu/drm/xe/xe_step.c
> @@ -6,6 +6,7 @@
> #include "xe_step.h"
>
> #include <linux/bitfield.h>
> +#include <kunit/visibility.h>
>
> #include "xe_device.h"
> #include "xe_platform_types.h"
> @@ -255,3 +256,4 @@ const char *xe_step_name(enum xe_step step)
> return "**";
> }
> }
> +EXPORT_SYMBOL_IF_KUNIT(xe_step_name);
> --
> 2.47.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
next prev parent reply other threads:[~2025-02-24 22:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 15:06 [PATCH v2 0/5] *Prepare RTP to define SR-IOV specific rules Michal Wajdeczko
2025-02-24 15:06 ` [PATCH v2 1/5] drm/xe/rtp: Prepare " Michal Wajdeczko
2025-02-24 19:41 ` Matt Roper
2025-02-24 23:36 ` Michal Wajdeczko
2025-02-25 3:04 ` Matt Roper
2025-02-26 14:24 ` Michał Winiarski
2025-02-24 15:06 ` [PATCH v2 2/5] drm/xe/sriov: Prepare IS_SRIOV_PF to accept const pointer Michal Wajdeczko
2025-02-24 22:39 ` Matt Roper
2025-02-24 15:06 ` [PATCH v2 3/5] drm/xe/kunit: Export xe_step_name for KUNIT Michal Wajdeczko
2025-02-24 22:45 ` Matt Roper [this message]
2025-02-24 15:06 ` [PATCH v2 4/5] drm/xe/kunit: Update RTP tests with SR-IOV rules Michal Wajdeczko
2025-02-24 22:55 ` Matt Roper
2025-02-24 23:41 ` Michal Wajdeczko
2025-02-25 3:10 ` Matt Roper
2025-02-25 15:09 ` Michal Wajdeczko
2025-02-25 23:07 ` Matt Roper
2025-02-24 15:07 ` [PATCH v2 5/5] drm/xe/rtp: Remove redundant rule to omit VF Michal Wajdeczko
2025-02-24 22:56 ` Matt Roper
2025-02-24 20:58 ` ✓ CI.Patch_applied: success for *Prepare RTP to define SR-IOV specific rules Patchwork
2025-02-24 20:58 ` ✓ CI.checkpatch: " Patchwork
2025-02-24 21:00 ` ✓ CI.KUnit: " Patchwork
2025-02-24 21:16 ` ✓ CI.Build: " Patchwork
2025-02-24 21:18 ` ✗ CI.Hooks: failure " Patchwork
2025-02-24 21:20 ` ✓ CI.checksparse: success " Patchwork
2025-02-25 6:41 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-25 8:07 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224224547.GC4460@mdroper-desk1.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox