From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com,
matthew.brost@intel.com, jianxun.zhang@intel.com,
dri-devel@lists.freedesktop.org
Subject: [PATCH v2 0/8] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
Date: Thu, 27 Feb 2025 19:14:49 +0000 [thread overview]
Message-ID: <20250227191457.84035-1-jonathan.cavitt@intel.com> (raw)
Add additional information to the xe_vm so it can report the last 50
relevant exec queues that have been banned on it, as well as the
associated pagefault address and address type that caused the ban when
applicable. Since we cannot reasonably associate a pagefault to a
specific exec queue, whenever a CAT error causes an exec queue to become
banned, we blame the last seen pagefault on said exec queue.
The last pagefault seen per exec queue is saved to the xe_vm, and the
pagefault is updated when a new pagefault is reported or when the last
pagefault has been associated with an exec queue, whichever happens
first. All new pagefault reports come from xe_gt_pagefault.
Also add a tracker that counts the number of times the VM has
experienced an engine reset.
Finally, add a new ioctl - xe_vm_get_property_ioctl - that allows the
user to query this additional information.
v2: (Matt Brost)
- Break full ban list request into a separate property.
- Reformat drm_xe_vm_get_property struct.
- Remove need for drm_xe_faults helper struct.
- Separate data pointer and scalar return value in ioctl.
- Get address type on pagefault report and save it to the pagefault.
- Correctly reject writes to read-only VMAs.
- Miscellaneous formatting fixes.
Signed-off-by: Jonathan Cavitt <joanthan.cavitt@intel.com>
Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Suggested-by: Matthew Brost <matthew.brost@intel.com>
CC: Zhang Jianxun <jianxun.zhang@intel.com>
Jonathan Cavitt (8):
drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs
drm/xe/xe_exec_queue: Add ID param to exec queue struct
drm/xe/xe_gt_pagefault: Migrate pagefault struct to header
drm/xe/xe_vm: Add per VM pagefault info
drm/xe/xe_vm: Add per VM reset stats
drm/xe/uapi: Define drm_xe_vm_get_property
drm/xe/xe_gt_pagefault: Add address_type field to pagefaults
drm/xe/xe_vm: Implement xe_vm_get_property_ioctl
drivers/gpu/drm/xe/xe_device.c | 3 +
drivers/gpu/drm/xe/xe_exec_queue.c | 7 +
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 +
drivers/gpu/drm/xe/xe_gt_pagefault.c | 65 ++++-----
drivers/gpu/drm/xe/xe_gt_pagefault.h | 29 ++++
drivers/gpu/drm/xe/xe_guc_submit.c | 4 +
drivers/gpu/drm/xe/xe_vm.c | 171 +++++++++++++++++++++++
drivers/gpu/drm/xe/xe_vm.h | 8 ++
drivers/gpu/drm/xe/xe_vm_types.h | 34 +++++
include/uapi/drm/xe_drm.h | 67 +++++++++
10 files changed, 356 insertions(+), 34 deletions(-)
--
2.43.0
next reply other threads:[~2025-02-27 19:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 19:14 Jonathan Cavitt [this message]
2025-02-27 19:14 ` [PATCH v2 1/8] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 2/8] drm/xe/xe_exec_queue: Add ID param to exec queue struct Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 3/8] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 4/8] drm/xe/xe_vm: Add per VM pagefault info Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 5/8] drm/xe/xe_vm: Add per VM reset stats Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 6/8] drm/xe/uapi: Define drm_xe_vm_get_property Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 7/8] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults Jonathan Cavitt
2025-02-27 19:14 ` [PATCH v2 8/8] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2025-02-28 3:44 ` kernel test robot
2025-02-27 21:01 ` ✓ CI.Patch_applied: success for drm/xe/xe_vm: Implement xe_vm_get_property_ioctl (rev2) Patchwork
2025-02-27 21:01 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-27 21:02 ` ✓ CI.KUnit: success " Patchwork
2025-02-27 21:19 ` ✓ CI.Build: " Patchwork
2025-02-27 21:21 ` ✓ CI.Hooks: " Patchwork
2025-02-27 21:23 ` ✓ CI.checksparse: " Patchwork
2025-02-27 21:43 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-02-28 2:08 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227191457.84035-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jianxun.zhang@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox