From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: himal.prasad.ghimiray@intel.com, apopple@nvidia.com,
airlied@gmail.com, thomas.hellstrom@linux.intel.com,
simona.vetter@ffwll.ch, felix.kuehling@amd.com, dakr@kernel.org
Subject: [PATCH v7 02/32] mm/migrate: Add migrate_device_pfns
Date: Wed, 5 Mar 2025 17:26:27 -0800 [thread overview]
Message-ID: <20250306012657.3505757-3-matthew.brost@intel.com> (raw)
In-Reply-To: <20250306012657.3505757-1-matthew.brost@intel.com>
Add migrate_device_pfns which prepares an array of pre-populated device
pages for migration. This is needed for eviction of known set of
non-contiguous devices pages to cpu pages which is a common case for SVM
in DRM drivers using TTM.
v2:
- s/migrate_device_vma_range/migrate_device_prepopulated_range
- Drop extra mmu invalidation (Vetter)
v3:
- s/migrate_device_prepopulated_range/migrate_device_pfns (Alistar)
- Use helper to lock device pages (Alistar)
- Update commit message with why this is required (Alistar)
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Alistair Popple <apopple@nvidia.com>
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
include/linux/migrate.h | 1 +
mm/migrate_device.c | 52 +++++++++++++++++++++++++++++------------
2 files changed, 38 insertions(+), 15 deletions(-)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index 29919faea2f1..80891120cca9 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -227,6 +227,7 @@ void migrate_vma_pages(struct migrate_vma *migrate);
void migrate_vma_finalize(struct migrate_vma *migrate);
int migrate_device_range(unsigned long *src_pfns, unsigned long start,
unsigned long npages);
+int migrate_device_pfns(unsigned long *src_pfns, unsigned long npages);
void migrate_device_pages(unsigned long *src_pfns, unsigned long *dst_pfns,
unsigned long npages);
void migrate_device_finalize(unsigned long *src_pfns,
diff --git a/mm/migrate_device.c b/mm/migrate_device.c
index 5bd888223cc8..e85ed4ab6df2 100644
--- a/mm/migrate_device.c
+++ b/mm/migrate_device.c
@@ -871,6 +871,22 @@ void migrate_vma_finalize(struct migrate_vma *migrate)
}
EXPORT_SYMBOL(migrate_vma_finalize);
+static unsigned long migrate_device_pfn_lock(unsigned long pfn)
+{
+ struct folio *folio;
+
+ folio = folio_get_nontail_page(pfn_to_page(pfn));
+ if (!folio)
+ return 0;
+
+ if (!folio_trylock(folio)) {
+ folio_put(folio);
+ return 0;
+ }
+
+ return migrate_pfn(pfn) | MIGRATE_PFN_MIGRATE;
+}
+
/**
* migrate_device_range() - migrate device private pfns to normal memory.
* @src_pfns: array large enough to hold migrating source device private pfns.
@@ -895,29 +911,35 @@ int migrate_device_range(unsigned long *src_pfns, unsigned long start,
{
unsigned long i, pfn;
- for (pfn = start, i = 0; i < npages; pfn++, i++) {
- struct folio *folio;
+ for (pfn = start, i = 0; i < npages; pfn++, i++)
+ src_pfns[i] = migrate_device_pfn_lock(pfn);
- folio = folio_get_nontail_page(pfn_to_page(pfn));
- if (!folio) {
- src_pfns[i] = 0;
- continue;
- }
+ migrate_device_unmap(src_pfns, npages, NULL);
- if (!folio_trylock(folio)) {
- src_pfns[i] = 0;
- folio_put(folio);
- continue;
- }
+ return 0;
+}
+EXPORT_SYMBOL(migrate_device_range);
- src_pfns[i] = migrate_pfn(pfn) | MIGRATE_PFN_MIGRATE;
- }
+/**
+ * migrate_device_pfns() - migrate device private pfns to normal memory.
+ * @src_pfns: pre-popluated array of source device private pfns to migrate.
+ * @npages: number of pages to migrate.
+ *
+ * Similar to migrate_device_range() but supports non-contiguous pre-popluated
+ * array of device pages to migrate.
+ */
+int migrate_device_pfns(unsigned long *src_pfns, unsigned long npages)
+{
+ unsigned long i;
+
+ for (i = 0; i < npages; i++)
+ src_pfns[i] = migrate_device_pfn_lock(src_pfns[i]);
migrate_device_unmap(src_pfns, npages, NULL);
return 0;
}
-EXPORT_SYMBOL(migrate_device_range);
+EXPORT_SYMBOL(migrate_device_pfns);
/*
* Migrate a device coherent folio back to normal memory. The caller should have
--
2.34.1
next prev parent reply other threads:[~2025-03-06 1:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 1:26 [PATCH v7 00/32] Introduce GPU SVM and Xe SVM implementation Matthew Brost
2025-03-06 1:26 ` [PATCH v7 01/32] drm/xe: Retry BO allocation Matthew Brost
2025-03-06 1:26 ` Matthew Brost [this message]
2025-03-06 1:26 ` [PATCH v7 03/32] mm/migrate: Trylock device page in do_swap_page Matthew Brost
2025-03-06 1:26 ` [PATCH v7 04/32] drm/pagemap: Add DRM pagemap Matthew Brost
2025-03-06 1:26 ` [PATCH v7 05/32] drm/xe/bo: Introduce xe_bo_put_async Matthew Brost
2025-03-06 1:26 ` [PATCH v7 06/32] drm/gpusvm: Add support for GPU Shared Virtual Memory Matthew Brost
2025-03-06 1:26 ` [PATCH v7 07/32] drm/xe: Select DRM_GPUSVM Kconfig Matthew Brost
2025-03-06 1:26 ` [PATCH v7 08/32] drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR Matthew Brost
2025-03-06 1:26 ` [PATCH v7 09/32] drm/xe: Add SVM init / close / fini to faulting VMs Matthew Brost
2025-03-06 1:26 ` [PATCH v7 10/32] drm/xe: Add dma_addr res cursor Matthew Brost
2025-03-06 1:26 ` [PATCH v7 11/32] drm/xe: Nuke VM's mapping upon close Matthew Brost
2025-03-06 1:26 ` [PATCH v7 12/32] drm/xe: Add SVM range invalidation and page fault Matthew Brost
2025-03-06 1:26 ` [PATCH v7 13/32] drm/gpuvm: Add DRM_GPUVA_OP_DRIVER Matthew Brost
2025-03-06 1:26 ` [PATCH v7 14/32] drm/xe: Add (re)bind to SVM page fault handler Matthew Brost
2025-03-06 1:26 ` [PATCH v7 15/32] drm/xe: Add SVM garbage collector Matthew Brost
2025-03-06 1:26 ` [PATCH v7 16/32] drm/xe: Add unbind to " Matthew Brost
2025-03-06 1:26 ` [PATCH v7 17/32] drm/xe: Do not allow CPU address mirror VMA unbind if Matthew Brost
2025-03-06 1:26 ` [PATCH v7 18/32] drm/xe: Enable CPU address mirror uAPI Matthew Brost
2025-03-06 1:26 ` [PATCH v7 19/32] drm/xe/uapi: Add DRM_XE_QUERY_CONFIG_FLAG_HAS_CPU_ADDR_MIRROR Matthew Brost
2025-03-06 1:26 ` [PATCH v7 20/32] drm/xe: Add migrate layer functions for SVM support Matthew Brost
2025-03-06 1:26 ` [PATCH v7 21/32] drm/xe: Add SVM device memory mirroring Matthew Brost
2025-03-06 1:26 ` [PATCH v7 22/32] drm/xe: Add drm_gpusvm_devmem to xe_bo Matthew Brost
2025-03-06 1:26 ` [PATCH v7 23/32] drm/xe: Add drm_pagemap ops to SVM Matthew Brost
2025-03-06 1:26 ` [PATCH v7 24/32] drm/xe: Add GPUSVM device memory copy vfunc functions Matthew Brost
2025-03-06 1:26 ` [PATCH v7 25/32] drm/xe: Add Xe SVM populate_devmem_pfn GPU SVM vfunc Matthew Brost
2025-03-06 1:26 ` [PATCH v7 26/32] drm/xe: Add Xe SVM devmem_release " Matthew Brost
2025-03-06 1:26 ` [PATCH v7 27/32] drm/xe: Add SVM VRAM migration Matthew Brost
2025-03-06 1:26 ` [PATCH v7 28/32] drm/xe: Basic SVM BO eviction Matthew Brost
2025-03-06 1:26 ` [PATCH v7 29/32] drm/xe: Add SVM debug Matthew Brost
2025-03-06 1:26 ` [PATCH v7 30/32] drm/xe: Add modparam for SVM notifier size Matthew Brost
2025-03-06 1:26 ` [PATCH v7 31/32] drm/xe: Add always_migrate_to_vram modparam Matthew Brost
2025-03-06 1:26 ` [PATCH v7 32/32] drm/doc: gpusvm: Add GPU SVM documentation Matthew Brost
2025-03-06 5:45 ` Alistair Popple
2025-03-06 6:08 ` Matthew Brost
2025-03-06 1:54 ` ✓ CI.Patch_applied: success for Introduce GPU SVM and Xe SVM implementation (rev7) Patchwork
2025-03-06 1:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-06 1:56 ` ✓ CI.KUnit: success " Patchwork
2025-03-06 2:12 ` ✓ CI.Build: " Patchwork
2025-03-06 2:14 ` ✓ CI.Hooks: " Patchwork
2025-03-06 2:16 ` ✗ CI.checksparse: warning " Patchwork
2025-03-06 2:51 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-06 8:25 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-06 9:57 ` Matthew Brost
2025-03-06 9:22 ` ✓ CI.Patch_applied: success for Introduce GPU SVM and Xe SVM implementation (rev8) Patchwork
2025-03-06 9:23 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-06 9:24 ` ✓ CI.KUnit: success " Patchwork
2025-03-06 9:41 ` ✓ CI.Build: " Patchwork
2025-03-06 9:43 ` ✓ CI.Hooks: " Patchwork
2025-03-06 9:44 ` ✗ CI.checksparse: warning " Patchwork
2025-03-06 10:17 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-03-06 18:41 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306012657.3505757-3-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=airlied@gmail.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=simona.vetter@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox