Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH 2/2] drm/xe/pm: Re-enable D3Cold by default on BMG
Date: Thu, 6 Mar 2025 16:36:15 -0500	[thread overview]
Message-ID: <20250306213615.1004502-3-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20250306213615.1004502-1-rodrigo.vivi@intel.com>

This patch re-enables D3Cold by default on BMG.

If issues on runtime_pm resume are seen and the D3cold->D0 transition
is suspected to block the device or cause memory corruptions, D3cold
can be disabled for confirmation with either:

1. at runtime:
   echo 0 > /sys/bus/pci/devices/<addr>/vram_d3cold_threshold

2. at boot:
   pcie_port_pm=off

Upon confirmation of D3Cold related bug, please file a bug to the
link below.

Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index a9f61a5fc971..12200be7b43d 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -287,7 +287,6 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
  */
 int xe_pm_init(struct xe_device *xe)
 {
-	u32 vram_threshold;
 	int err;
 
 	/* For now suspend/resume is only allowed with GuC */
@@ -301,11 +300,7 @@ int xe_pm_init(struct xe_device *xe)
 		if (err)
 			return err;
 
-		/* FIXME: D3Cold temporarily disabled by default on BMG */
-		vram_threshold = xe->info.platform == XE_BATTLEMAGE ? 0 :
-				DEFAULT_VRAM_THRESHOLD;
-
-		err = xe_pm_set_vram_threshold(xe, vram_threshold);
+		err = xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
 		if (err)
 			return err;
 	}
-- 
2.48.1


  parent reply	other threads:[~2025-03-06 21:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 21:36 [PATCH 0/2] Battlemage D3Cold issues Rodrigo Vivi
2025-03-06 21:36 ` [PATCH 1/2] drm/xe/pm: Temporarily disable D3Cold on BMG Rodrigo Vivi
2025-03-07 22:15   ` Lucas De Marchi
2025-03-08  0:49     ` Rodrigo Vivi
2025-03-06 21:36 ` Rodrigo Vivi [this message]
2025-03-06 21:41 ` ✓ CI.Patch_applied: success for Battlemage D3Cold issues Patchwork
2025-03-06 21:42 ` ✓ CI.checkpatch: " Patchwork
2025-03-06 21:43 ` ✓ CI.KUnit: " Patchwork
2025-03-06 21:59 ` ✓ CI.Build: " Patchwork
2025-03-06 22:02 ` ✓ CI.Hooks: " Patchwork
2025-03-06 22:03 ` ✓ CI.checksparse: " Patchwork
2025-03-06 22:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-07  5:22 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250306213615.1004502-3-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox