From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH] drm/i915/psr: Check transcoder Selective Update support for PR as well
Date: Fri, 7 Mar 2025 14:00:35 +0200 [thread overview]
Message-ID: <20250307120035.2976127-1-jouni.hogander@intel.com> (raw)
We need to ensure transcoder is supporting Selective Update in case of
Panel Replay as well.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 74aa7ba34fda..84e4d6f1f3a8 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1491,13 +1491,6 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
return false;
}
- if (!transcoder_has_psr2(display, crtc_state->cpu_transcoder)) {
- drm_dbg_kms(display->drm,
- "PSR2 not supported in transcoder %s\n",
- transcoder_name(crtc_state->cpu_transcoder));
- return false;
- }
-
/*
* DSC and PSR2 cannot be enabled simultaneously. If a requested
* resolution requires DSC to be enabled, priority is given to DSC
@@ -1579,6 +1572,13 @@ static bool intel_sel_update_config_valid(struct intel_dp *intel_dp,
goto unsupported;
}
+ if (!transcoder_has_psr2(display, crtc_state->cpu_transcoder)) {
+ drm_dbg_kms(display->drm,
+ "Selective update not supported in transcoder %s\n",
+ transcoder_name(crtc_state->cpu_transcoder));
+ goto unsupported;
+ }
+
if (!crtc_state->has_panel_replay && !intel_psr2_config_valid(intel_dp, crtc_state))
goto unsupported;
--
2.43.0
next reply other threads:[~2025-03-07 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:00 Jouni Högander [this message]
2025-03-07 12:54 ` ✓ CI.Patch_applied: success for drm/i915/psr: Check transcoder Selective Update support for PR as well Patchwork
2025-03-07 12:55 ` ✓ CI.checkpatch: " Patchwork
2025-03-07 12:56 ` ✓ CI.KUnit: " Patchwork
2025-03-07 13:13 ` ✓ CI.Build: " Patchwork
2025-03-07 13:15 ` ✓ CI.Hooks: " Patchwork
2025-03-07 13:17 ` ✓ CI.checksparse: " Patchwork
2025-03-07 13:36 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-08 8:43 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-21 9:19 ` [PATCH] " Manna, Animesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307120035.2976127-1-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox