Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Riana Tauro <riana.tauro@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: riana.tauro@intel.com, anshuman.gupta@intel.com,
	rodrigo.vivi@intel.com, matthew.d.roper@intel.com,
	lucas.demarchi@intel.com
Subject: [PATCH 1/2] RFC drm/xe: Add configfs to enable survivability mode
Date: Fri,  7 Mar 2025 19:54:44 +0530	[thread overview]
Message-ID: <20250307142446.1790715-2-riana.tauro@intel.com> (raw)
In-Reply-To: <20250307142446.1790715-1-riana.tauro@intel.com>

Registers a configfs subsystem called 'xe' to userspace. The user can
use this to modify exposed attributes.

Add survivability mode attribute (config/xe/survivability_mode) to the
subsystem to allow the user to specify the card that should enter
survivability mode.

Signed-off-by: Riana Tauro <riana.tauro@intel.com>
---
 drivers/gpu/drm/xe/Makefile      |  1 +
 drivers/gpu/drm/xe/xe_configfs.c | 95 ++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h | 12 ++++
 drivers/gpu/drm/xe/xe_module.c   |  5 ++
 drivers/gpu/drm/xe/xe_module.h   |  1 +
 5 files changed, 114 insertions(+)
 create mode 100644 drivers/gpu/drm/xe/xe_configfs.c
 create mode 100644 drivers/gpu/drm/xe/xe_configfs.h

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 9699b08585f7..3f8c87292cee 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -28,6 +28,7 @@ $(obj)/generated/%_wa_oob.c $(obj)/generated/%_wa_oob.h: $(obj)/xe_gen_wa_oob \
 xe-y += xe_bb.o \
 	xe_bo.o \
 	xe_bo_evict.o \
+	xe_configfs.o \
 	xe_devcoredump.o \
 	xe_device.o \
 	xe_device_sysfs.o \
diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
new file mode 100644
index 000000000000..8c5f248e466d
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_configfs.c
@@ -0,0 +1,95 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+#include <linux/configfs.h>
+#include <linux/init.h>
+#include <linux/module.h>
+
+#include "xe_configfs.h"
+#include "xe_module.h"
+
+/**
+ * DOC: Xe Configfs
+ *
+ * XE KMD registers a configfs subsystem called 'xe'to userspace that allows users to modify
+ * the exposed attributes.
+ *
+ * Attributes:
+ *
+ * config/xe/survivability_mode : Write only attribute that allows user to specify the PCI address
+ *				  of the card that has to enter survivability mode
+ */
+
+void xe_configfs_clear_survivability_mode(void)
+{
+	kfree(xe_modparam.survivability_mode);
+	xe_modparam.survivability_mode = NULL;
+}
+
+static ssize_t survivability_mode_store(struct config_item *item, const char *page, size_t len)
+{
+	char *survivability_mode;
+	int ret;
+	unsigned int domain, bus, slot, function;
+
+	ret = sscanf(page, "%04x:%02x:%02x.%x", &domain, &bus, &slot, &function);
+	if (ret != 4)
+		return -EINVAL;
+
+	survivability_mode = kstrdup(page, GFP_KERNEL);
+	if (!survivability_mode)
+		return -ENOMEM;
+
+	xe_configfs_clear_survivability_mode();
+	xe_modparam.survivability_mode = survivability_mode;
+
+	return len;
+}
+
+CONFIGFS_ATTR_WO(, survivability_mode);
+
+static struct configfs_attribute *xe_configfs_attrs[] = {
+	&attr_survivability_mode,
+	NULL,
+};
+
+static const struct config_item_type xe_config_type = {
+	.ct_attrs	= xe_configfs_attrs,
+	.ct_owner	= THIS_MODULE,
+};
+
+static struct configfs_subsystem xe_config_subsys = {
+	.su_group = {
+		.cg_item = {
+			.ci_namebuf = "xe",
+			.ci_type = &xe_config_type,
+		},
+	},
+};
+
+int __init xe_configfs_init(void)
+{
+	int ret;
+
+	config_group_init(&xe_config_subsys.su_group);
+	mutex_init(&xe_config_subsys.su_mutex);
+	ret = configfs_register_subsystem(&xe_config_subsys);
+	if (ret) {
+		pr_err("Error %d while registering subsystem %s\n",
+		       ret, xe_config_subsys.su_group.cg_item.ci_namebuf);
+		mutex_destroy(&xe_config_subsys.su_mutex);
+		return ret;
+	}
+
+	return 0;
+}
+
+void __exit xe_configfs_exit(void)
+{
+	xe_configfs_clear_survivability_mode();
+	configfs_unregister_subsystem(&xe_config_subsys);
+	mutex_destroy(&xe_config_subsys.su_mutex);
+}
+
diff --git a/drivers/gpu/drm/xe/xe_configfs.h b/drivers/gpu/drm/xe/xe_configfs.h
new file mode 100644
index 000000000000..491629a2ca53
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_configfs.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+#ifndef _XE_CONFIGFS_H_
+#define _XE_CONFIGFS_H_
+
+int xe_configfs_init(void);
+void xe_configfs_exit(void);
+void xe_configfs_clear_survivability_mode(void);
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
index 475acdba2b55..15b3cf22193c 100644
--- a/drivers/gpu/drm/xe/xe_module.c
+++ b/drivers/gpu/drm/xe/xe_module.c
@@ -11,6 +11,7 @@
 #include <drm/drm_module.h>
 
 #include "xe_drv.h"
+#include "xe_configfs.h"
 #include "xe_hw_fence.h"
 #include "xe_pci.h"
 #include "xe_pm.h"
@@ -91,6 +92,10 @@ static const struct init_funcs init_funcs[] = {
 	{
 		.init = xe_check_nomodeset,
 	},
+	{
+		.init = xe_configfs_init,
+		.exit = xe_configfs_exit,
+	},
 	{
 		.init = xe_hw_fence_module_init,
 		.exit = xe_hw_fence_module_exit,
diff --git a/drivers/gpu/drm/xe/xe_module.h b/drivers/gpu/drm/xe/xe_module.h
index 84339e509c80..c238dbee6bc7 100644
--- a/drivers/gpu/drm/xe/xe_module.h
+++ b/drivers/gpu/drm/xe/xe_module.h
@@ -24,6 +24,7 @@ struct xe_modparam {
 #endif
 	int wedged_mode;
 	u32 svm_notifier_size;
+	char *survivability_mode;
 };
 
 extern struct xe_modparam xe_modparam;
-- 
2.47.1


  reply	other threads:[~2025-03-07 14:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 14:24 [PATCH 0/2] Add configfs support for survivability mode Riana Tauro
2025-03-07 14:24 ` Riana Tauro [this message]
2025-03-07 14:45   ` [PATCH 1/2] RFC drm/xe: Add configfs to enable " Rodrigo Vivi
2025-03-07 15:16   ` Lucas De Marchi
2025-03-10  5:31     ` Riana Tauro
2025-03-10 13:31       ` Lucas De Marchi
2025-03-10 14:23         ` Riana Tauro
2025-03-10 16:40           ` Rodrigo Vivi
2025-03-10 17:01             ` Lucas De Marchi
2025-03-10 17:14               ` Rodrigo Vivi
2025-03-10 21:40                 ` Matt Roper
2025-03-10  7:14   ` Aravind Iddamsetty
2025-03-13  6:18     ` Riana Tauro
2025-03-13 14:52       ` Rodrigo Vivi
2025-03-13 19:52         ` Lucas De Marchi
2025-03-14  7:24           ` Riana Tauro
2025-03-14 16:17             ` Aravind Iddamsetty
2025-03-07 14:24 ` [PATCH 2/2] RFC drm/xe: Enable configfs support for " Riana Tauro
2025-03-07 15:01   ` Rodrigo Vivi
2025-03-10  5:36     ` Riana Tauro
2025-03-07 14:36 ` ✓ CI.Patch_applied: success for Add " Patchwork
2025-03-07 14:36 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-07 14:37 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307142446.1790715-2-riana.tauro@intel.com \
    --to=riana.tauro@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox