Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [CI 2/2] drm/xe/pm: Re-enable D3Cold by default on BMG
Date: Fri, 7 Mar 2025 19:56:36 -0500	[thread overview]
Message-ID: <20250308005636.1475420-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20250308005636.1475420-1-rodrigo.vivi@intel.com>

This patch re-enables D3Cold by default on BMG.

If issues on runtime_pm resume are seen and the D3cold->D0 transition
is suspected to block the device or cause memory corruptions, D3cold
can be disabled for confirmation with either:

1. at runtime:
   echo 0 > /sys/bus/pci/devices/<addr>/vram_d3cold_threshold

2. at boot:
   pcie_port_pm=off

Upon confirmation of D3Cold related bug, please file a bug to the
link below.

Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index 7b6b754ad6eb..a7ddf45db886 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -279,10 +279,6 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
 
 static u32 vram_threshold_value(struct xe_device *xe)
 {
-	/* FIXME: D3Cold temporarily disabled by default on BMG */
-	if (xe->info.platform == XE_BATTLEMAGE)
-		return 0;
-
 	return DEFAULT_VRAM_THRESHOLD;
 }
 
-- 
2.48.1


  reply	other threads:[~2025-03-08  0:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08  0:56 [CI 1/2] drm/xe/pm: Temporarily disable D3Cold on BMG Rodrigo Vivi
2025-03-08  0:56 ` Rodrigo Vivi [this message]
2025-03-21 18:23   ` [CI 2/2] drm/xe/pm: Re-enable D3Cold by default " Lucas De Marchi
2025-03-24 14:31     ` Rodrigo Vivi
2025-03-08  2:28 ` ✓ CI.Patch_applied: success for series starting with [CI,1/2] drm/xe/pm: Temporarily disable D3Cold " Patchwork
2025-03-08  2:28 ` ✓ CI.checkpatch: " Patchwork
2025-03-08  2:29 ` ✓ CI.KUnit: " Patchwork
2025-03-08  2:46 ` ✓ CI.Build: " Patchwork
2025-03-08  2:48 ` ✓ CI.Hooks: " Patchwork
2025-03-08  2:50 ` ✓ CI.checksparse: " Patchwork
2025-03-08  3:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-09 21:56 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250308005636.1475420-2-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox