From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
ville.syrjala@linux.intel.com,
mitulkumar.ajitkumar.golani@intel.com
Subject: [PATCH 06/21] drm/i915/vrr: Use crtc_vtotal for vmin
Date: Mon, 10 Mar 2025 17:46:00 +0530 [thread overview]
Message-ID: <20250310121615.1077079-7-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250310121615.1077079-1-ankit.k.nautiyal@intel.com>
To have fixed refresh rate with VRR timing generator the
guardband/pipeline full can't be programmed on the fly. So we need to
ensure that the values satisfy both the fixed and variable refresh
rates.
Since we compute these value based on vmin, lets set the vmin to
crtc_vtotal for both fixed and variable timings instead of using the
current refresh rate based approach. This way the guardband remains
sufficient for both cases.
v2: Avoid using vblank delay while computing vtotal, as this comes into
the picture later. (Ville)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 7320eb97991f..e0573e28014b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -247,17 +247,16 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state)
}
static
-int intel_vrr_compute_vmin(struct intel_connector *connector,
- const struct drm_display_mode *adjusted_mode)
+int intel_vrr_compute_vmin(struct intel_crtc_state *crtc_state)
{
- const struct drm_display_info *info = &connector->base.display_info;
- int vmin;
-
- vmin = DIV_ROUND_UP(adjusted_mode->crtc_clock * 1000,
- adjusted_mode->crtc_htotal * info->monitor_range.max_vfreq);
- vmin = max_t(int, vmin, adjusted_mode->crtc_vtotal);
-
- return vmin;
+ /*
+ * To make fixed rr and vrr work seamless the guardband/pipeline full
+ * should be set such that it satisfies both the fixed and variable
+ * timings.
+ * For this set the vmin as crtc_vtotal. With this we never need to
+ * change anything to do with the guardband.
+ */
+ return crtc_state->hw.adjusted_mode.crtc_vtotal;
}
static
@@ -304,7 +303,7 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
if (HAS_LRR(display))
crtc_state->update_lrr = true;
- vmin = intel_vrr_compute_vmin(connector, adjusted_mode);
+ vmin = intel_vrr_compute_vmin(crtc_state);
vmax = intel_vrr_compute_vmax(connector, adjusted_mode);
if (vmin >= vmax)
--
2.45.2
next prev parent reply other threads:[~2025-03-10 12:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 12:15 [PATCH 00/21] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2025-03-10 12:15 ` [PATCH 01/21] drm/i915/vrr: Remove unwanted comment Ankit Nautiyal
2025-03-10 12:15 ` [PATCH 02/21] drm/i915:vrr: Separate out functions to compute vmin and vmax Ankit Nautiyal
2025-03-10 12:15 ` [PATCH 03/21] drm/i915/vrr: Make helpers for cmrr and vrr timings Ankit Nautiyal
2025-03-10 12:15 ` [PATCH 04/21] drm/i915/vrr: Disable CMRR Ankit Nautiyal
2025-03-10 12:15 ` [PATCH 05/21] drm/i915/vrr: Track vrr.enable only for variable timing Ankit Nautiyal
2025-03-10 12:16 ` Ankit Nautiyal [this message]
2025-03-10 12:16 ` [PATCH 07/21] drm/i915/vrr: Prepare for fixed refresh rate timings Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 08/21] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 09/21] drm/i915/hdmi: Use VRR Timing generator for HDMI for fixed_rr Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 10/21] drm/i915/dp_mst: Use VRR Timing generator for DP MST " Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 11/21] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 12/21] drm/i915/display: Move intel_psr_post_plane_update() at the later Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 13/21] drm/i915/vrr: Refactor condition for computing vmax and LRR Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 14/21] drm/i915/vrr: Always set vrr vmax/vmin/flipline in vrr_{enable/disable} Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 15/21] drm/i915/display: Use fixed_rr timings in modeset sequence Ankit Nautiyal
2025-03-10 18:07 ` Ville Syrjälä
2025-03-11 8:54 ` Nautiyal, Ankit K
2025-03-10 12:16 ` [PATCH 16/21] drm/i915/vrr: Use fixed timings for platforms that support VRR Ankit Nautiyal
2025-03-10 12:16 ` [PATCH 17/21] drm/i915/display: Use fixed rr timings in intel_set_transcoder_timings_lrr() Ankit Nautiyal
2025-03-10 18:08 ` Ville Syrjälä
2025-03-10 12:16 ` [PATCH 18/21] drm/i915/display: Move vrr.guardband/pipeline_full out of !fastset block Ankit Nautiyal
2025-03-10 18:09 ` Ville Syrjälä
2025-03-10 12:16 ` [PATCH 19/21] drm/i915/vrr: Allow fixed_rr with pipe joiner Ankit Nautiyal
2025-03-10 18:10 ` Ville Syrjälä
2025-03-10 12:16 ` [PATCH 20/21] drm/i915/vrr: Always use VRR timing generator for MTL+ Ankit Nautiyal
2025-03-10 18:12 ` Ville Syrjälä
2025-03-11 8:21 ` Nautiyal, Ankit K
2025-03-10 12:16 ` [PATCH 21/21] drm/i915/display: Add fixed_rr to crtc_state dump Ankit Nautiyal
2025-03-10 18:13 ` Ville Syrjälä
2025-03-10 13:22 ` ✓ CI.Patch_applied: success for Use VRR timing generator for fixed refresh rate modes (rev8) Patchwork
2025-03-10 13:22 ` ✓ CI.checkpatch: " Patchwork
2025-03-10 13:23 ` ✓ CI.KUnit: " Patchwork
2025-03-10 13:40 ` ✓ CI.Build: " Patchwork
2025-03-10 13:43 ` ✓ CI.Hooks: " Patchwork
2025-03-10 13:45 ` ✗ CI.checksparse: warning " Patchwork
2025-03-10 14:08 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-11 9:40 ` ✗ Xe.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-03-06 13:10 [PATCH 00/21] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2025-03-06 13:10 ` [PATCH 06/21] drm/i915/vrr: Use crtc_vtotal for vmin Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310121615.1077079-7-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox