Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
	ville.syrjala@linux.intel.com,
	mitulkumar.ajitkumar.golani@intel.com
Subject: [RESEND PATCH 4/8] drm/i915/vrr: Disable CMRR
Date: Tue, 11 Mar 2025 15:07:47 +0530	[thread overview]
Message-ID: <20250311093751.1329043-5-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250311093751.1329043-1-ankit.k.nautiyal@intel.com>

Switching between variable and fixed timings is possible as for that we
just need to flip between VRR timings. However for CMRR along with the
timings, few other bits also need to be changed on the fly, which might
cause issues. So disable CMRR for now, till we have variable and fixed
timings sorted out.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index db0ea206e26e..a57659820f4b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -182,7 +182,8 @@ is_cmrr_frac_required(struct intel_crtc_state *crtc_state)
 	int calculated_refresh_k, actual_refresh_k, pixel_clock_per_line;
 	struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
 
-	if (!HAS_CMRR(display))
+	/* Avoid CMRR for now till we have VRR with fixed timings working */
+	if (!HAS_CMRR(display) || true)
 		return false;
 
 	actual_refresh_k =
-- 
2.45.2


  parent reply	other threads:[~2025-03-11  9:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11  9:37 [RESEND PATCH 0/8] VRR Refactor Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 1/8] drm/i915/vrr: Remove unwanted comment Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 2/8] drm/i915:vrr: Separate out functions to compute vmin and vmax Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 3/8] drm/i915/vrr: Make helpers for cmrr and vrr timings Ankit Nautiyal
2025-03-11  9:37 ` Ankit Nautiyal [this message]
2025-03-11  9:37 ` [RESEND PATCH 5/8] drm/i915/vrr: Track vrr.enable only for variable timing Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 6/8] drm/i915/vrr: Use crtc_vtotal for vmin Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 7/8] drm/i915/vrr: Prepare for fixed refresh rate timings Ankit Nautiyal
2025-03-11  9:37 ` [RESEND PATCH 8/8] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode Ankit Nautiyal
2025-03-11  9:57 ` ✓ CI.Patch_applied: success for VRR Refactor Patchwork
2025-03-11  9:58 ` ✓ CI.checkpatch: " Patchwork
2025-03-11 10:00 ` ✓ CI.KUnit: " Patchwork
2025-03-11 10:19 ` ✓ CI.Build: " Patchwork
2025-03-11 10:21 ` ✓ CI.Hooks: " Patchwork
2025-03-11 10:22 ` ✓ CI.checksparse: " Patchwork
2025-03-11 10:44 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-12  3:44 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-13 13:31 ` [RESEND PATCH 0/8] " Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250311093751.1329043-5-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox