Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-xe <intel-xe@lists.freedesktop.org>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Francois Dugast <francois.dugast@intel.com>,
	Riana Tauro <riana.tauro@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 0/3] drm/xe: Fix survivability
Date: Wed, 12 Mar 2025 14:11:48 -0700	[thread overview]
Message-ID: <20250312-fix-survivability-v3-0-54620dbcbbd7@intel.com> (raw)

It turns out commit d40f275d96e8 ("drm/xe: Move survivability entirely
to xe_pci") did a bad job moving things to xe_pci. The fix provided by
Riana in 20250306055407.511405-1-riana.tauro@intel.com fixes it
partially, but injecting a failure in xe_pcode_probe_early still causes
the kernel to give warnings/errors.

Correct the course and better split what is done in xe_pci vs xe_device.
This time, also add a patch to test we can handle errors in
xe_pcode_probe_early().

Entering survivability mode was tested with an additional one line to
change the return of xe_survivability_mode_capable(). If we want to
inject error, we'd need to change it's return type, but there's also
another patch series to force it via configs, so this doesn't seem very
important right now.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
Changes in v3:
- Add another fix for heci
- Rename function according to review feedback
- Link to v2: https://lore.kernel.org/r/20250311-fix-survivability-v2-0-729ce081155e@intel.com

Changes in v2:
- Cover more error injections in the second patch
- Link to v1: https://lore.kernel.org/r/20250310-fix-survivability-v1-0-7af31432bbd0@intel.com

---
Lucas De Marchi (3):
      drm/xe: Move survivability back to xe
      drm/xe: Set survivability mode before heci init
      drm/xe: Allow to inject error in early probe

 drivers/gpu/drm/xe/xe_device.c             | 16 +++++++++++++++-
 drivers/gpu/drm/xe/xe_mmio.c               |  1 +
 drivers/gpu/drm/xe/xe_pci.c                | 16 +++++++---------
 drivers/gpu/drm/xe/xe_pcode.c              |  2 ++
 drivers/gpu/drm/xe/xe_survivability_mode.c | 29 +++++++++++++++++++++--------
 drivers/gpu/drm/xe/xe_survivability_mode.h |  1 -
 6 files changed, 46 insertions(+), 19 deletions(-)
---
base-commit: aba848f9b752cf51474c0c3b1abcf0f572f774dc
change-id: 20250310-fix-survivability-703246c0c480

Best regards,
-- 
Lucas De Marchi <lucas.demarchi@intel.com>


             reply	other threads:[~2025-03-12 21:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 21:11 Lucas De Marchi [this message]
2025-03-12 21:11 ` [PATCH v3 1/3] drm/xe: Move survivability back to xe Lucas De Marchi
2025-03-13  6:00   ` Riana Tauro
2025-03-14 13:43     ` Lucas De Marchi
2025-03-12 21:11 ` [PATCH v3 2/3] drm/xe: Set survivability mode before heci init Lucas De Marchi
2025-03-13  5:32   ` Riana Tauro
2025-03-12 21:11 ` [PATCH v3 3/3] drm/xe: Allow to inject error in early probe Lucas De Marchi
2025-03-12 22:12 ` ✓ CI.Patch_applied: success for drm/xe: Fix survivability (rev3) Patchwork
2025-03-12 22:12 ` ✓ CI.checkpatch: " Patchwork
2025-03-12 22:13 ` ✓ CI.KUnit: " Patchwork
2025-03-12 22:30 ` ✓ CI.Build: " Patchwork
2025-03-12 22:32 ` ✓ CI.Hooks: " Patchwork
2025-03-12 22:33 ` ✓ CI.checksparse: " Patchwork
2025-03-12 23:12 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-13 15:19 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312-fix-survivability-v3-0-54620dbcbbd7@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox