From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96AE6C35FF4 for ; Thu, 13 Mar 2025 18:34:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 584F210E918; Thu, 13 Mar 2025 18:34:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Xb2IipNQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 889F410E90B; Thu, 13 Mar 2025 18:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741890858; x=1773426858; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hl8+lM11PRLmxBjMwYzmp398zmvgVeUwbwpOM7K9t/8=; b=Xb2IipNQIrag+pWyVvQ8UnucM8QN5iyDfCwIK0EX2FH3+bu56NVhBM9+ UuRyzq6/esQxcTvkKPId47rUn4cKQaNkHZOiaqcKrxWKIwbn28YcnZYfn DHk+30LWlyzbuVWaTuERHCtw0T8t6/axCqh9OT10Ro+K+pHNjcj3DBAXP WU6JPRyVM9azzg2Fco5wkkaFr4Aw0//I5tnfT8s74PxfjVhV59ZmYI1yu QOihGiTOHRjM5qkEXnUhnGkMbVFSut7lmc20oE54PjCF9yiS1jVmKfOgy IDhjiiybNn98UdgHFPAtjcsvagO+YOwbF0A7wOhoWF4i/7Rp5lAzDiL0D Q==; X-CSE-ConnectionGUID: A1/nnJVIQAm23V6myUDq2Q== X-CSE-MsgGUID: MBHg7NNgReiuZSCtyRo7/Q== X-IronPort-AV: E=McAfee;i="6700,10204,11372"; a="65485457" X-IronPort-AV: E=Sophos;i="6.14,245,1736841600"; d="scan'208";a="65485457" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 11:34:17 -0700 X-CSE-ConnectionGUID: 8U47uYS4Td+rN0ax8s9C+A== X-CSE-MsgGUID: LXrRZbVrSsm6oU2XC0xykQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,245,1736841600"; d="scan'208";a="151900769" Received: from dut4440lnl.fm.intel.com ([10.105.10.40]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 11:34:17 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mzorek@intel.com Subject: [PATCH v8 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs Date: Thu, 13 Mar 2025 18:34:03 +0000 Message-ID: <20250313183415.133863-2-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313183415.133863-1-jonathan.cavitt@intel.com> References: <20250313183415.133863-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c index 9fa11e837dd1..3240890aac07 100644 --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c @@ -237,6 +237,11 @@ static int handle_pagefault(struct xe_gt *gt, struct pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && pf->access_type != ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = access_is_atomic(pf->access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0