Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Zhanjun Dong <zhanjun.dong@intel.com>,
	Julia Filipchuk <julia.filipchuk@intel.com>
Subject: [PATCH v2] drm/xe/guc: Disable lite restore for MTL
Date: Wed, 19 Mar 2025 10:28:25 -0700	[thread overview]
Message-ID: <20250319172825.3334036-1-zhanjun.dong@intel.com> (raw)

Lite restore for MTL is not POR for Xe, then disable it for MTL.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
Changes from prior revs:
  v2:- Changed long conditional initialization to simple if statement.

 drivers/gpu/drm/xe/xe_guc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index bc5714a5b36b..d9a0daf584b4 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -80,9 +80,13 @@ static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 
 static u32 guc_ctl_feature_flags(struct xe_guc *guc)
 {
+	struct xe_device *xe = guc_to_xe(guc);
 	u32 flags = GUC_CTL_ENABLE_LITE_RESTORE;
 
-	if (!guc_to_xe(guc)->info.skip_guc_pc)
+	if (xe->info.platform == XE_METEORLAKE)
+		flags &= ~GUC_CTL_ENABLE_LITE_RESTORE;
+
+	if (!xe->info.skip_guc_pc)
 		flags |= GUC_CTL_ENABLE_SLPC;
 
 	return flags;
-- 
2.34.1


             reply	other threads:[~2025-03-19 17:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 17:28 Zhanjun Dong [this message]
2025-03-19 17:33 ` ✓ CI.Patch_applied: success for drm/xe/guc: Disable lite restore for MTL (rev2) Patchwork
2025-03-19 17:33 ` ✓ CI.checkpatch: " Patchwork
2025-03-19 17:34 ` ✓ CI.KUnit: " Patchwork
2025-03-19 17:51 ` ✓ CI.Build: " Patchwork
2025-03-19 17:53 ` ✓ CI.Hooks: " Patchwork
2025-03-19 17:54 ` ✓ CI.checksparse: " Patchwork
2025-03-19 18:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-19 19:15 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-19 20:20 ` [PATCH v2] drm/xe/guc: Disable lite restore for MTL John Harrison
2025-03-20 10:23   ` Kenneth Graunke
2025-03-20 14:27     ` Dong, Zhanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319172825.3334036-1-zhanjun.dong@intel.com \
    --to=zhanjun.dong@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=julia.filipchuk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox