From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 899C3C28B30 for ; Thu, 20 Mar 2025 19:27:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D36510E69D; Thu, 20 Mar 2025 19:27:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="FQ+ibtHN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6728A10E69D for ; Thu, 20 Mar 2025 19:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742498848; x=1774034848; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CLFhajjTbW4XpWKwKV/sroTp007sMTWnVXoX3MT/pQc=; b=FQ+ibtHNeUOm+8Ofk9zOos3DzR2rdmGHTeaUtXIgNRvpVrIkSWSOgx0z vOgTPxeBL933FEJvbW9p6JIvCC8qmTiVffNGRBSYeYOOiOYl4ZlPrQRVb 5MO/KNET85hr7FqwpqxdjZgZI2F7sxxzrEsjJJUcgVRWUsnTKUXrzhNlh 7ESny+EZMX4Bq8vDblNUsb2E51xnfvJ5fXbDghgSHz1ty06UViTLlJUJG BP8gVx6/zX9lpORQxnv0GStn9ofOLJLCsG4ucDXO4zV3Cj9XR5cQxK8lH w78iLX4vlBkTe+zo2zAqM9YoP/183IfC/xnghVs4rJetMX9Lai4I63rSB Q==; X-CSE-ConnectionGUID: Gmx96kvwR3q6D9p56mPz8w== X-CSE-MsgGUID: Nxz6uK0mQ3ScFRu9f8XlCg== X-IronPort-AV: E=McAfee;i="6700,10204,11379"; a="43678747" X-IronPort-AV: E=Sophos;i="6.14,262,1736841600"; d="scan'208";a="43678747" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 12:27:22 -0700 X-CSE-ConnectionGUID: mb3arcWBQjugy7PN3OqtGg== X-CSE-MsgGUID: DIUIHdPWQtaZDry3SVv/Vw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,262,1736841600"; d="scan'208";a="123156813" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 12:27:22 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Cc: jose.souza@intel.com, carlos.santa@intel.com Subject: [PATCH v3 3/9] drm/xe: Add mem_region to properties line in VM snapshot capture Date: Thu, 20 Mar 2025 12:28:25 -0700 Message-Id: <20250320192831.3842138-4-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250320192831.3842138-1-matthew.brost@intel.com> References: <20250320192831.3842138-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Add memory region to properties line in VM snapshot capture indicating where the memory is located. The memory region corresponds to regions in the uAPI. This is useful information for debug and will help build a robust GPU hang replay tool. The current format is: []: ||mem_region=0x%x Permissions has two options, either "read_only" or "read_write". Type has three options, either "userptr", "null_sparse", or "bo". Memory region is a bit mask of where the memory is located. Cc: José Roberto de Souza Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_vm.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index 8718fba3a6f3..a95d5765a258 100644 --- a/drivers/gpu/drm/xe/xe_vm.c +++ b/drivers/gpu/drm/xe/xe_vm.c @@ -3713,6 +3713,7 @@ struct xe_vm_snapshot { #define XE_VM_SNAP_FLAG_READ_ONLY BIT(1) #define XE_VM_SNAP_FLAG_IS_NULL BIT(2) unsigned long flags; + int uapi_mem_region; struct xe_bo *bo; void *data; struct mm_struct *mm; @@ -3758,6 +3759,18 @@ struct xe_vm_snapshot *xe_vm_snapshot_capture(struct xe_vm *vm) if (bo) { snap->snap[i].bo = xe_bo_get(bo); snap->snap[i].bo_ofs = xe_vma_bo_offset(vma); + switch (bo->ttm.resource->mem_type) { + case XE_PL_SYSTEM: + case XE_PL_TT: + snap->snap[i].uapi_mem_region = 0; + break; + case XE_PL_VRAM0: + snap->snap[i].uapi_mem_region = 1; + break; + case XE_PL_VRAM1: + snap->snap[i].uapi_mem_region = 2; + break; + } } else if (xe_vma_is_userptr(vma)) { struct mm_struct *mm = to_userptr_vma(vma)->userptr.notifier.mm; @@ -3769,10 +3782,13 @@ struct xe_vm_snapshot *xe_vm_snapshot_capture(struct xe_vm *vm) snap->snap[i].bo_ofs = xe_vma_userptr(vma); snap->snap[i].flags |= XE_VM_SNAP_FLAG_USERPTR; + snap->snap[i].uapi_mem_region = 0; } else if (xe_vma_is_null(vma)) { snap->snap[i].flags |= XE_VM_SNAP_FLAG_IS_NULL; + snap->snap[i].uapi_mem_region = -1; } else { snap->snap[i].data = ERR_PTR(-ENOENT); + snap->snap[i].uapi_mem_region = -1; } i++; } @@ -3841,13 +3857,16 @@ void xe_vm_snapshot_print(struct xe_vm_snapshot *snap, struct drm_printer *p) for (i = 0; i < snap->num_snaps; i++) { drm_printf(p, "[%llx].length: 0x%lx\n", snap->snap[i].ofs, snap->snap[i].len); - drm_printf(p, "[%llx].properties: %s|%s\n", snap->snap[i].ofs, + drm_printf(p, "[%llx].properties: %s|%s|mem_region=0x%lx\n", + snap->snap[i].ofs, snap->snap[i].flags & XE_VM_SNAP_FLAG_READ_ONLY ? "read_only" : "read_write", snap->snap[i].flags & XE_VM_SNAP_FLAG_IS_NULL ? "null_sparse" : snap->snap[i].flags & XE_VM_SNAP_FLAG_USERPTR ? - "userptr" : "bo"); + "userptr" : "bo", + snap->snap[i].uapi_mem_region == -1 ? 0 : + BIT(snap->snap[i].uapi_mem_region)); if (IS_ERR(snap->snap[i].data)) { drm_printf(p, "[%llx].error: %li\n", snap->snap[i].ofs, -- 2.34.1