From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 1/2] drm/i915/pps: Let calling intel_pps_vdd_{on, off}_unlocked() w/o PPS lock held
Date: Mon, 24 Mar 2025 20:01:44 +0200 [thread overview]
Message-ID: <20250324180145.142884-2-imre.deak@intel.com> (raw)
In-Reply-To: <20250324180145.142884-1-imre.deak@intel.com>
After a follow-up change on non-eDP outputs
intel_pps_vdd_{on,off}_unlocked() can be called without the PPS lock
held, allow for this.
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_pps.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 617ce49931726..c883e872c9c82 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -744,11 +744,11 @@ bool intel_pps_vdd_on_unlocked(struct intel_dp *intel_dp)
i915_reg_t pp_stat_reg, pp_ctrl_reg;
bool need_to_disable = !intel_dp->pps.want_panel_vdd;
- lockdep_assert_held(&display->pps.mutex);
-
if (!intel_dp_is_edp(intel_dp))
return false;
+ lockdep_assert_held(&display->pps.mutex);
+
cancel_delayed_work(&intel_dp->pps.panel_vdd_work);
intel_dp->pps.want_panel_vdd = true;
@@ -925,11 +925,11 @@ void intel_pps_vdd_off_unlocked(struct intel_dp *intel_dp, bool sync)
{
struct intel_display *display = to_intel_display(intel_dp);
- lockdep_assert_held(&display->pps.mutex);
-
if (!intel_dp_is_edp(intel_dp))
return;
+ lockdep_assert_held(&display->pps.mutex);
+
INTEL_DISPLAY_STATE_WARN(display, !intel_dp->pps.want_panel_vdd,
"[ENCODER:%d:%s] %s VDD not forced on",
dp_to_dig_port(intel_dp)->base.base.base.id,
--
2.44.2
next prev parent reply other threads:[~2025-03-24 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 18:01 [PATCH v2 0/2] drm/i915: Fix DP MST DB message timeouts due to PPS delays Imre Deak
2025-03-24 18:01 ` Imre Deak [this message]
2025-03-24 18:01 ` [PATCH v2 2/2] drm/i915/dp_mst: Fix side-band message timeouts due to long " Imre Deak
2025-03-24 18:35 ` ✓ CI.Patch_applied: success for drm/i915: Fix DP MST DB message timeouts due to " Patchwork
2025-03-24 18:35 ` ✓ CI.checkpatch: " Patchwork
2025-03-24 18:36 ` ✓ CI.KUnit: " Patchwork
2025-03-24 18:53 ` ✓ CI.Build: " Patchwork
2025-03-24 18:55 ` ✓ CI.Hooks: " Patchwork
2025-03-24 18:57 ` ✗ CI.checksparse: warning " Patchwork
2025-03-24 19:21 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-24 21:53 ` ✓ Xe.CI.Full: " Patchwork
2025-03-25 9:27 ` [PATCH v2 0/2] " Jani Nikula
[not found] ` <174285700806.75091.7982901296370240968@18a75f3d1eae>
2025-03-25 12:29 ` ✗ i915.CI.Full: failure for " Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324180145.142884-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox