From: Stuart Summers <stuart.summers@intel.com>
Cc: stuart.summers@intel.com, john.c.harrison@intel.com,
intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe/guc: Use drm_info for hwconfig missing message in execlist mode
Date: Thu, 27 Mar 2025 20:22:01 +0000 [thread overview]
Message-ID: <20250327202201.15169-1-stuart.summers@intel.com> (raw)
When running in execlist mode we are explicitly not loading
the GuC firmware and the GuC is needed to provide the hwconfig
values. Currently we are printing an error message any time
we see the hwconfig couldn't be obtained for some reason which
is breaking the execlist specific CI.
Keep the error message for normal GuC based load, but when
the module is loaded with force_execlist=1, change this to
an info print.
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
drivers/gpu/drm/xe/xe_gt_mcr.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
index 605aad3554e7..52ee2ead3b17 100644
--- a/drivers/gpu/drm/xe/xe_gt_mcr.c
+++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
@@ -345,8 +345,18 @@ static unsigned int dss_per_group(struct xe_gt *gt)
* Some older platforms don't have tables or don't have complete tables.
* Newer platforms should always have the required info.
*/
- if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000)
- xe_gt_err(gt, "Slice/Subslice counts missing from hwconfig table; using typical fallback values\n");
+ if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000) {
+ const char *fallback_msg =
+ "GT%u: Slice/Subslice counts missing from hwconfig table; using typical fallback values\n";
+ struct drm_printer ip = xe_gt_info_printer(gt);
+ struct drm_printer ep = xe_gt_err_printer(gt);
+
+ /* In execlist, we don't load GuC, so this is expected. */
+ if (gt_to_xe(gt)->info.force_execlist)
+ drm_printf(&ip, fallback_msg, gt->info.id);
+ else
+ drm_printf(&ep, fallback_msg, gt->info.id);
+ }
if (gt_to_xe(gt)->info.platform == XE_PVC)
return 8;
--
2.34.1
next reply other threads:[~2025-03-27 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 20:22 Stuart Summers [this message]
2025-03-27 20:27 ` ✓ CI.Patch_applied: success for drm/xe/guc: Use drm_info for hwconfig missing message in execlist mode Patchwork
2025-03-27 20:27 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-27 20:28 ` ✓ CI.KUnit: success " Patchwork
2025-03-27 20:45 ` ✓ CI.Build: " Patchwork
2025-03-27 20:47 ` ✓ CI.Hooks: " Patchwork
2025-03-27 20:48 ` ✓ CI.checksparse: " Patchwork
2025-03-27 21:21 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-28 6:09 ` [PATCH] " Lucas De Marchi
2025-03-28 15:32 ` Summers, Stuart
2025-03-28 8:03 ` ✗ Xe.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327202201.15169-1-stuart.summers@intel.com \
--to=stuart.summers@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox