Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>
Subject: [PATCH v2 2/7] drm/gpusvm: use more selective dma dir in get_pages()
Date: Fri, 28 Mar 2025 18:10:31 +0000	[thread overview]
Message-ID: <20250328181028.288312-11-matthew.auld@intel.com> (raw)
In-Reply-To: <20250328181028.288312-9-matthew.auld@intel.com>

If we are only reading the memory then from the device pov the direction
can be DMA_TO_DEVICE. This aligns with the xe-userptr code. Using the
most restrictive data direction to represent the access is normally a
good idea.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/drm_gpusvm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
index 07dda042624c..e0c8d450752a 100644
--- a/drivers/gpu/drm/drm_gpusvm.c
+++ b/drivers/gpu/drm/drm_gpusvm.c
@@ -1363,6 +1363,8 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
 	int err = 0;
 	struct dev_pagemap *pagemap;
 	struct drm_pagemap *dpagemap;
+	enum dma_data_direction dma_dir = ctx->read_only ? DMA_TO_DEVICE :
+							   DMA_BIDIRECTIONAL;
 
 retry:
 	hmm_range.notifier_seq = mmu_interval_read_begin(notifier);
@@ -1467,7 +1469,7 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
 				dpagemap->ops->device_map(dpagemap,
 							  gpusvm->drm->dev,
 							  page, order,
-							  DMA_BIDIRECTIONAL);
+							  dma_dir);
 			if (dma_mapping_error(gpusvm->drm->dev,
 					      range->dma_addr[j].addr)) {
 				err = -EFAULT;
@@ -1486,7 +1488,7 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
 			addr = dma_map_page(gpusvm->drm->dev,
 					    page, 0,
 					    PAGE_SIZE << order,
-					    DMA_BIDIRECTIONAL);
+					    dma_dir);
 			if (dma_mapping_error(gpusvm->drm->dev, addr)) {
 				err = -EFAULT;
 				goto err_unmap;
@@ -1494,7 +1496,7 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm,
 
 			range->dma_addr[j] = drm_pagemap_device_addr_encode
 				(addr, DRM_INTERCONNECT_SYSTEM, order,
-				 DMA_BIDIRECTIONAL);
+				 dma_dir);
 		}
 		i += 1 << order;
 		num_dma_mapped = i;
-- 
2.48.1


  parent reply	other threads:[~2025-03-28 18:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 18:10 [PATCH v2 0/7] Replace xe_hmm with gpusvm Matthew Auld
2025-03-28 18:10 ` [PATCH v2 1/7] drm/gpusvm: fix hmm_pfn_to_map_order() usage Matthew Auld
2025-03-28 18:10 ` Matthew Auld [this message]
2025-03-28 18:10 ` [PATCH v2 3/7] drm/gpusvm: pull out drm_gpusvm_pages substructure Matthew Auld
2025-04-03 21:15   ` Matthew Brost
2025-03-28 18:10 ` [PATCH v2 4/7] drm/gpusvm: refactor core API to use pages struct Matthew Auld
2025-03-28 18:10 ` [PATCH v2 5/7] drm/gpusvm: export drm_gpusvm_pages API Matthew Auld
2025-03-28 18:10 ` [PATCH v2 6/7] drm/xe/userptr: replace xe_hmm with gpusvm Matthew Auld
2025-03-28 18:10 ` [PATCH v2 7/7] drm/xe/pt: unify xe_pt_svm_pre_commit with userptr Matthew Auld
2025-04-03 21:23   ` Matthew Brost
2025-04-04  8:20     ` Matthew Auld
2025-04-03 21:25   ` Matthew Brost
2025-04-04  8:19     ` Matthew Auld
2025-04-04 17:02       ` Matthew Brost
2025-04-07  7:29         ` Matthew Auld
2025-04-23 16:20           ` Matthew Brost
2025-03-28 20:46 ` ✓ CI.Patch_applied: success for Replace xe_hmm with gpusvm (rev2) Patchwork
2025-03-28 20:47 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-28 20:47 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250328181028.288312-11-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox