From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: [PATCH] drm/xe: Restore EIO errno return when GuC PC start fails
Date: Fri, 28 Mar 2025 14:17:52 -0400 [thread overview]
Message-ID: <20250328181752.26677-1-rodrigo.vivi@intel.com> (raw)
Commit b4b05e53b550 ("drm/xe/guc_pc: Retry and wait longer for GuC PC
start") from Mar 7, 2025 (linux-next), leads to the following Smatch
static checker warning:
drivers/gpu/drm/xe/xe_guc_pc.c:1073 xe_guc_pc_start()
warn: missing error code here? '_dev_err()' failed. 'ret' = '0'
Fixes: b4b05e53b550 ("drm/xe/guc_pc: Retry and wait longer for GuC PC start")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-xe/1454a5f1-ee18-4df1-a6b2-a4a3dddcd1cb@stanley.mountain/
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_guc_pc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 85215313976c..43b1192ba61c 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -1070,6 +1070,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
if (wait_for_pc_state(pc, SLPC_GLOBAL_STATE_RUNNING,
SLPC_RESET_EXTENDED_TIMEOUT_MS)) {
xe_gt_err(gt, "GuC PC Start failed: Dynamic GT frequency control and GT sleep states are now disabled.\n");
+ ret = -EIO;
goto out;
}
--
2.49.0
next reply other threads:[~2025-03-28 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 18:17 Rodrigo Vivi [this message]
2025-03-28 20:52 ` ✓ CI.Patch_applied: success for drm/xe: Restore EIO errno return when GuC PC start fails Patchwork
2025-03-28 20:52 ` ✓ CI.checkpatch: " Patchwork
2025-03-28 20:53 ` ✓ CI.KUnit: " Patchwork
2025-03-28 21:10 ` ✓ CI.Build: " Patchwork
2025-03-28 21:12 ` ✓ CI.Hooks: " Patchwork
2025-03-28 21:14 ` ✓ CI.checksparse: " Patchwork
2025-03-28 21:48 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-29 13:01 ` ✓ Xe.CI.Full: " Patchwork
2025-03-31 14:59 ` [PATCH] " Lucas De Marchi
2025-03-31 15:26 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328181752.26677-1-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox