Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sobin Thomas <sobin.thomas@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: tejas.upadhyay@intel.com
Subject: drm/xe: xe_hw_engine_class: Add fault injection and improve error handling in kobj_xe_hw_engine_class
Date: Sat,  5 Apr 2025 07:17:03 +0000	[thread overview]
Message-ID: <20250405071703.2255259-1-sobin.thomas@intel.com> (raw)

- Added fault injection for `kobj_xe_hw_engine_class` to enhance coverage.
- Improved error handling by checking for `IS_ERR_OR_NULL` on `keclass` and
  propagating the error using `PTR_ERR`.

Can be tested using inject-fault-probe-function-kobj_xe_hw_engine_class

Signed-off-by: Sobin Thomas <sobin.thomas@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
index 640950172088..0cafe1175389 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
@@ -571,6 +571,7 @@ kobj_xe_hw_engine_class(struct xe_device *xe, struct kobject *parent, const char
 
 	return keclass;
 }
+ALLOW_ERROR_INJECTION(kobj_xe_hw_engine_class, NULL);
 
 static void hw_engine_class_defaults_fini(void *arg)
 {
@@ -662,8 +663,8 @@ int xe_hw_engine_class_sysfs_init(struct xe_gt *gt)
 		}
 
 		keclass = kobj_xe_hw_engine_class(xe, kobj, name);
-		if (!keclass) {
-			err = -EINVAL;
+		if (IS_ERR_OR_NULL(keclass)) {
+			err = PTR_ERR(keclass);
 			goto err_object;
 		}
 
-- 
2.34.1


             reply	other threads:[~2025-04-05  7:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-05  7:17 Sobin Thomas [this message]
2025-04-05  8:26 ` ✓ CI.Patch_applied: success for drm/xe: xe_hw_engine_class: Add fault injection and improve error handling in kobj_xe_hw_engine_class Patchwork
2025-04-05  8:27 ` ✓ CI.checkpatch: " Patchwork
2025-04-05  8:28 ` ✓ CI.KUnit: " Patchwork
2025-04-05  8:44 ` ✓ CI.Build: " Patchwork
2025-04-05  8:47 ` ✓ CI.Hooks: " Patchwork
2025-04-05  8:48 ` ✓ CI.checksparse: " Patchwork
2025-04-07  3:29 ` Upadhyay, Tejas
2025-04-07 10:22 ` Michal Wajdeczko
2025-04-07 13:15 ` ✓ CI.Patch_applied: success for drm/xe: xe_hw_engine_class: Add fault injection and improve error handling in kobj_xe_hw_engine_class (rev2) Patchwork
2025-04-07 13:15 ` ✓ CI.checkpatch: " Patchwork
2025-04-07 13:16 ` ✓ CI.KUnit: " Patchwork
2025-04-07 13:20 ` ✗ CI.Build: failure " Patchwork
2025-04-07 20:56 ` ✗ Xe.CI.Full: failure for drm/xe: xe_hw_engine_class: Add fault injection and improve error handling in kobj_xe_hw_engine_class Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250405071703.2255259-1-sobin.thomas@intel.com \
    --to=sobin.thomas@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=tejas.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox