From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 667B0C3601E for ; Mon, 7 Apr 2025 05:58:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CAB510E1D6; Mon, 7 Apr 2025 05:58:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hmRnOe8R"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B12810E29F; Mon, 7 Apr 2025 05:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744005511; x=1775541511; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=n4Lcw+o2tFGVugwxTR3rGGz0X1EHJ8/82iNTtwvQg+Q=; b=hmRnOe8RmRD9J/ZAGng7/D1u/uhl7D37OBSIwz1BZzXIOetBvJxLJxtt p87A4YvOmK2ri+sQHCf9ztAaAY6wWuLrYB6D6vOPTvw9Y3sK5tq6uAlYL YZCk1OHaYkfbMR6Q8e4v9oyqWxsGgv4jqWSr33KMFiQVtjW9uGKh0bs4b 8sznbCVzH+WxIIgLfSfx64pEtZqImRvx3iHdjYkgqZz7moKzhKvmv2Ae4 peSPAxNmZHEVoalgpa0Mzywrj2J/W766tOjqhOxxef6w89UoEkeypkn5A Wfxt6GTJdnYPOhGes/VQ3nkHWs8I9A7k7bR+U6MWAvbUyWYr9UjAOV6p9 g==; X-CSE-ConnectionGUID: sPVnc54kSg6cMrL4dAOyXQ== X-CSE-MsgGUID: q3q5bAdtSfOX5PJ7SzkrLw== X-IronPort-AV: E=McAfee;i="6700,10204,11396"; a="45391847" X-IronPort-AV: E=Sophos;i="6.15,193,1739865600"; d="scan'208";a="45391847" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2025 22:58:31 -0700 X-CSE-ConnectionGUID: nwpRI4jOQlK1zb/ughfAZA== X-CSE-MsgGUID: ySvPRbK0Q7eS/3jBtuWLvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,193,1739865600"; d="scan'208";a="128373991" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orviesa007.jf.intel.com with ESMTP; 06 Apr 2025 22:58:29 -0700 From: Arun R Murthy Date: Mon, 07 Apr 2025 11:13:49 +0530 Subject: [PATCH RESEND v13 5/5] drm/i915/display: Indexed 8bit format does not support async flip MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250407-asyn-v13-5-b93ef83076c5@intel.com> References: <20250407-asyn-v13-0-b93ef83076c5@intel.com> In-Reply-To: <20250407-asyn-v13-0-b93ef83076c5@intel.com> To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Jani Nikula , chaitanya.kumar.borah@intel.com, ville.syrjala@intel.com, Arun R Murthy , =?utf-8?q?Ville_Syrj=C3=A4l=C3=A4?= X-Mailer: b4 0.15-dev X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Async flip is not supported with Indexed 8 bit format as it depends on LUT and can't be updated atomically. Note: This may change the alignment for C8 framebuffers on some platforms. Signed-off-by: Arun R Murthy Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c index 3b9d3e1620cd882b8a7f9b4c96640e42367248bb..1bcfa5f4fd63442b632655ccaf325a87be78fe21 100644 --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c @@ -177,7 +177,8 @@ bool intel_plane_needs_physical(struct intel_plane *plane) bool intel_plane_can_async_flip(struct intel_plane *plane, u32 format, u64 modifier) { - if (intel_format_info_is_yuv_semiplanar(drm_format_info(format), modifier)) + if (intel_format_info_is_yuv_semiplanar(drm_format_info(format), modifier) || + format == DRM_FORMAT_C8) return false; return plane->can_async_flip && plane->can_async_flip(modifier); -- 2.25.1