From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [PATCH 00/19] drm: Eliminate redundant drm_format_info lookups
Date: Thu, 10 Apr 2025 19:31:59 +0300 [thread overview]
Message-ID: <20250410163218.15130-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I noticed a bunch of redundant (and rather expensive) drm_format_info
lookups in some traces recently. This series is an attempt to eliminate
them.
Ville Syrjälä (19):
drm: Pass pixel_format+modifier to .get_format_info()
drm: Pass pixel_format+modifier directly to drm_get_format_info()
drm: Look up the format info earlier
drm: Pass the format info to .fb_create()
drm: Allow the caller to pass in the format info to
drm_helper_mode_fill_fb_struct()
drm/malidp: Pass along the format info from .fb_create()
malidp_verify_afbc_framebuffer_size()
drm/gem: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/gem/afbc: Eliminate redundant drm_get_format_info()
drm/amdgpu: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/armada: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/exynos: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/gma500: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/i915: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/komeda: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/msm: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/tegra: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/virtio: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm/vmwgfx: Pass along the format info from .fb_create() to
drm_helper_mode_fill_fb_struct()
drm: Make passing of format info to drm_helper_mode_fill_fb_struct()
mandatory
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 1 +
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 4 +-
.../amd/display/amdgpu_dm/amdgpu_dm_plane.h | 2 +-
.../arm/display/komeda/komeda_framebuffer.c | 3 +-
.../arm/display/komeda/komeda_framebuffer.h | 1 +
drivers/gpu/drm/arm/malidp_drv.c | 12 +++---
drivers/gpu/drm/armada/armada_fb.c | 12 +++---
drivers/gpu/drm/armada/armada_fb.h | 4 +-
drivers/gpu/drm/armada/armada_fbdev.c | 5 ++-
drivers/gpu/drm/drm_fourcc.c | 7 ++--
drivers/gpu/drm/drm_framebuffer.c | 27 ++++++-------
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 38 ++++++++-----------
drivers/gpu/drm/drm_modeset_helper.c | 4 +-
drivers/gpu/drm/exynos/exynos_drm_fb.c | 7 ++--
drivers/gpu/drm/exynos/exynos_drm_fb.h | 1 +
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 5 ++-
drivers/gpu/drm/gma500/fbdev.c | 5 ++-
drivers/gpu/drm/gma500/framebuffer.c | 14 ++++---
drivers/gpu/drm/gma500/psb_drv.h | 1 +
drivers/gpu/drm/i915/display/intel_fb.c | 18 +++++----
drivers/gpu/drm/i915/display/intel_fb.h | 5 ++-
drivers/gpu/drm/i915/display/intel_fbdev_fb.c | 6 ++-
.../drm/i915/display/intel_plane_initial.c | 3 +-
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 ++-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +--
drivers/gpu/drm/msm/msm_drv.h | 3 +-
drivers/gpu/drm/msm/msm_fb.c | 18 +++++----
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +----
drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++-
drivers/gpu/drm/nouveau/nouveau_display.h | 1 +
drivers/gpu/drm/omapdrm/omap_fb.c | 10 ++---
drivers/gpu/drm/omapdrm/omap_fb.h | 3 +-
drivers/gpu/drm/qxl/qxl_display.c | 3 +-
drivers/gpu/drm/radeon/radeon_display.c | 3 +-
drivers/gpu/drm/radeon/radeon_fbdev.c | 3 +-
drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 3 +-
drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 +-
.../gpu/drm/renesas/shmobile/shmob_drm_kms.c | 3 +-
drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 11 ++----
drivers/gpu/drm/tegra/drm.h | 2 +
drivers/gpu/drm/tegra/fb.c | 7 ++--
drivers/gpu/drm/tegra/fbdev.c | 4 +-
drivers/gpu/drm/tests/drm_framebuffer_test.c | 1 +
drivers/gpu/drm/vc4/vc4_kms.c | 3 +-
drivers/gpu/drm/virtio/virtgpu_display.c | 6 ++-
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 15 +++++---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 1 +
drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 6 ++-
drivers/gpu/drm/xe/display/xe_plane_initial.c | 2 +-
drivers/gpu/drm/xen/xen_drm_front_kms.c | 3 +-
drivers/gpu/drm/xlnx/zynqmp_kms.c | 3 +-
include/drm/drm_fourcc.h | 2 +-
include/drm/drm_gem_framebuffer_helper.h | 6 +++
include/drm/drm_mode_config.h | 3 +-
include/drm/drm_modeset_helper.h | 2 +
56 files changed, 207 insertions(+), 139 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-10 16:32 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 16:31 Ville Syrjala [this message]
2025-04-10 16:32 ` [PATCH 01/19] drm: Pass pixel_format+modifier to .get_format_info() Ville Syrjala
2025-04-10 19:27 ` Laurent Pinchart
2025-04-11 6:47 ` Ville Syrjälä
2025-04-11 19:19 ` [PATCH v2 " Ville Syrjala
2025-04-10 16:32 ` [PATCH 02/19] drm: Pass pixel_format+modifier directly to drm_get_format_info() Ville Syrjala
2025-04-10 19:31 ` Laurent Pinchart
2025-04-10 19:43 ` kernel test robot
2025-04-11 7:23 ` Thomas Zimmermann
2025-04-11 19:27 ` [PATCH v2 " Ville Syrjala
2025-04-10 16:32 ` [PATCH 03/19] drm: Look up the format info earlier Ville Syrjala
2025-04-10 19:33 ` Laurent Pinchart
2025-04-11 7:01 ` Ville Syrjälä
2025-04-11 7:18 ` Thomas Zimmermann
2025-04-11 19:27 ` [PATCH v2 " Ville Syrjala
2025-04-10 16:32 ` [PATCH 04/19] drm: Pass the format info to .fb_create() Ville Syrjala
2025-04-10 19:37 ` Laurent Pinchart
2025-04-10 21:26 ` kernel test robot
2025-04-11 6:36 ` Geert Uytterhoeven
2025-04-11 19:29 ` [PATCH v2 " Ville Syrjala
2025-04-10 16:32 ` [PATCH 05/19] drm: Allow the caller to pass in the format info to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-04-10 19:38 ` Laurent Pinchart
2025-04-10 16:32 ` [PATCH 06/19] drm/malidp: Pass along the format info from .fb_create() malidp_verify_afbc_framebuffer_size() Ville Syrjala
2025-04-10 16:32 ` [PATCH 07/19] drm/gem: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-04-10 19:39 ` Laurent Pinchart
2025-04-10 22:58 ` kernel test robot
2025-04-11 19:31 ` [PATCH v2 " Ville Syrjala
2025-04-10 16:32 ` [PATCH 08/19] drm/gem/afbc: Eliminate redundant drm_get_format_info() Ville Syrjala
2025-04-10 16:32 ` [PATCH 09/19] drm/amdgpu: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-04-10 16:32 ` [PATCH 10/19] drm/armada: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 11/19] drm/exynos: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 12/19] drm/gma500: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 13/19] drm/i915: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 14/19] drm/komeda: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 15/19] drm/msm: " Ville Syrjala
2025-04-10 19:28 ` Dmitry Baryshkov
2025-04-10 16:32 ` [PATCH 16/19] drm/tegra: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 17/19] drm/virtio: " Ville Syrjala
2025-04-16 6:44 ` Dmitry Osipenko
2025-04-10 16:32 ` [PATCH 18/19] drm/vmwgfx: " Ville Syrjala
2025-04-10 16:32 ` [PATCH 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory Ville Syrjala
2025-04-10 19:40 ` Laurent Pinchart
2025-04-10 18:46 ` ✓ CI.Patch_applied: success for drm: Eliminate redundant drm_format_info lookups Patchwork
2025-04-10 18:47 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10 18:48 ` ✓ CI.KUnit: success " Patchwork
2025-04-10 19:03 ` ✓ CI.Build: " Patchwork
2025-04-10 19:05 ` ✓ CI.Hooks: " Patchwork
2025-04-10 19:06 ` ✗ CI.checksparse: warning " Patchwork
2025-04-10 19:51 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-11 0:20 ` ✗ Xe.CI.Full: " Patchwork
2025-04-11 7:30 ` [PATCH 00/19] " Thomas Zimmermann
2025-04-11 19:54 ` ✓ CI.Patch_applied: success for drm: Eliminate redundant drm_format_info lookups (rev2) Patchwork
2025-04-11 19:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-11 19:56 ` ✓ CI.KUnit: success " Patchwork
2025-04-11 20:04 ` ✓ CI.Build: " Patchwork
2025-04-11 20:06 ` ✓ CI.Hooks: " Patchwork
2025-04-11 20:08 ` ✗ CI.checksparse: warning " Patchwork
2025-04-11 20:58 ` ✓ Xe.CI.BAT: success " Patchwork
2025-04-11 22:07 ` ✓ CI.Patch_applied: success for drm: Eliminate redundant drm_format_info lookups (rev6) Patchwork
2025-04-11 22:08 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-11 22:09 ` ✓ CI.KUnit: success " Patchwork
2025-04-11 22:18 ` ✓ CI.Build: " Patchwork
2025-04-11 22:20 ` ✓ CI.Hooks: " Patchwork
2025-04-11 22:22 ` ✗ CI.checksparse: warning " Patchwork
2025-04-11 22:48 ` ✓ Xe.CI.BAT: success " Patchwork
2025-04-11 23:03 ` ✗ Xe.CI.Full: failure for drm: Eliminate redundant drm_format_info lookups (rev2) Patchwork
2025-04-12 0:56 ` ✗ Xe.CI.Full: failure for drm: Eliminate redundant drm_format_info lookups (rev6) Patchwork
2025-07-15 18:21 ` [PATCH 00/19] drm: Eliminate redundant drm_format_info lookups Alex Deucher
2025-07-15 18:22 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410163218.15130-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox