From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF82C369A2 for ; Thu, 10 Apr 2025 19:41:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0091410EA71; Thu, 10 Apr 2025 19:41:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jThzMrpt"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FD1E10EA6D; Thu, 10 Apr 2025 19:41:14 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 436D1496; Thu, 10 Apr 2025 21:39:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1744313954; bh=gApCB9zDj21uPasiuBjC0Wsj5Q1jjZkIFqZxl7WupEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jThzMrpt/vs+OHImLU74rzY7H8ltkVMrbdoKwONTsfSN05KMIYO2a1lO1NVHAwNgB 5bDfszKnXnnmvoVcRX2srWVmVChTuD3AjvpQ3Z/f6uU7rke+tXXdxEhPqnmRGYBG/e btu9bPeZ/Qu7ATYafZztAK9DkVqhCktvFK7j3Uyo= Date: Thu, 10 Apr 2025 22:40:47 +0300 From: Laurent Pinchart To: Ville Syrjala Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory Message-ID: <20250410194047.GG27834@pendragon.ideasonboard.com> References: <20250410163218.15130-1-ville.syrjala@linux.intel.com> <20250410163218.15130-20-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250410163218.15130-20-ville.syrjala@linux.intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Ville, Thank you for the patch. On Thu, Apr 10, 2025 at 07:32:18PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that everyone passes along the format info to > drm_helper_mode_fill_fb_struct() we can make this behaviour > mandatory and drop the extra lookup. > > Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_modeset_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c > index ae2a83ecb1cf..3c153d420822 100644 > --- a/drivers/gpu/drm/drm_modeset_helper.c > +++ b/drivers/gpu/drm/drm_modeset_helper.c > @@ -86,8 +86,7 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev, > int i; > > fb->dev = dev; > - fb->format = info ? : drm_get_format_info(dev, mode_cmd->pixel_format, > - mode_cmd->modifier[0]); > + fb->format = info; > fb->width = mode_cmd->width; > fb->height = mode_cmd->height; > for (i = 0; i < 4; i++) { -- Regards, Laurent Pinchart