From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH v3 3/4] drm/xe/guc: Rename CONFIG_XE_LARGE_GUC_BUFFER
Date: Wed, 7 May 2025 18:34:36 -0700 [thread overview]
Message-ID: <20250508013437.652982-4-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20250508013437.652982-1-John.C.Harrison@Intel.com>
From: John Harrison <John.C.Harrison@Intel.com>
Rename XE_LARGE_GUC_BUFFER to XE_DEBUG_GUC to allow for more debug
only code (in subsequent patch) without adding more config defines
that each control only a single thing.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
drivers/gpu/drm/xe/Kconfig.debug | 8 +++++---
drivers/gpu/drm/xe/xe_guc_log.h | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/Kconfig.debug b/drivers/gpu/drm/xe/Kconfig.debug
index 0d749ed44878..db063a513b1e 100644
--- a/drivers/gpu/drm/xe/Kconfig.debug
+++ b/drivers/gpu/drm/xe/Kconfig.debug
@@ -86,12 +86,14 @@ config DRM_XE_KUNIT_TEST
If in doubt, say "N".
-config DRM_XE_LARGE_GUC_BUFFER
- bool "Enable larger guc log buffer"
+config DRM_XE_DEBUG_GUC
+ bool "Enable extra GuC related debug options"
+ depends on DRM_XE_DEBUG
default n
help
Choose this option when debugging guc issues.
- Buffer should be large enough for complex issues.
+ The GuC log buffer is increased to the maximum allowed, which should
+ be large enough for complex issues.
Recommended for driver developers only.
diff --git a/drivers/gpu/drm/xe/xe_guc_log.h b/drivers/gpu/drm/xe/xe_guc_log.h
index 5b896f5fafaf..f1e2b0be90a9 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.h
+++ b/drivers/gpu/drm/xe/xe_guc_log.h
@@ -12,7 +12,7 @@
struct drm_printer;
struct xe_device;
-#if IS_ENABLED(CONFIG_DRM_XE_LARGE_GUC_BUFFER)
+#if IS_ENABLED(CONFIG_DRM_XE_DEBUG_GUC)
#define CRASH_BUFFER_SIZE SZ_1M
#define DEBUG_BUFFER_SIZE SZ_8M
#define CAPTURE_BUFFER_SIZE SZ_2M
--
2.49.0
next prev parent reply other threads:[~2025-05-08 1:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 1:34 [PATCH v3 0/4] Track FAST_REQ H2Gs to report where errors came from John.C.Harrison
2025-05-08 1:34 ` [PATCH v3 1/4] drm/xe/guc: Remove double blank line John.C.Harrison
2025-05-08 19:37 ` Michal Wajdeczko
2025-05-08 1:34 ` [PATCH v3 2/4] drm/xe/guc: Add missing H2G error code definitions John.C.Harrison
2025-05-08 19:50 ` Michal Wajdeczko
2025-05-12 19:30 ` John Harrison
2025-05-08 1:34 ` John.C.Harrison [this message]
2025-05-08 19:52 ` [PATCH v3 3/4] drm/xe/guc: Rename CONFIG_XE_LARGE_GUC_BUFFER Michal Wajdeczko
2025-05-08 1:34 ` [PATCH v3 4/4] drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from John.C.Harrison
2025-05-08 20:11 ` Michal Wajdeczko
2025-05-12 19:52 ` John Harrison
2025-05-08 1:40 ` ✓ CI.Patch_applied: success for Track FAST_REQ H2Gs to report where errors came from (rev2) Patchwork
2025-05-08 1:40 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-08 1:41 ` ✓ CI.KUnit: success " Patchwork
2025-05-08 1:50 ` ✓ CI.Build: " Patchwork
2025-05-08 1:52 ` ✓ CI.Hooks: " Patchwork
2025-05-08 1:53 ` ✓ CI.checksparse: " Patchwork
2025-05-08 2:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-08 22:58 ` ✗ Xe.CI.Full: failure " Patchwork
2025-05-26 18:39 ` ✗ CI.Patch_applied: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508013437.652982-4-John.C.Harrison@Intel.com \
--to=john.c.harrison@intel.com \
--cc=Intel-Xe@Lists.FreeDesktop.Org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox