Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Laguna <lukasz.laguna@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, rodrigo.vivi@intel.com,
	matthew.brost@intel.com, lukasz.laguna@intel.com
Subject: [PATCH v2 2/4] drm/xe: Don't update wedged mode in case of an error
Date: Mon, 12 May 2025 18:34:30 +0200	[thread overview]
Message-ID: <20250512163432.22678-3-lukasz.laguna@intel.com> (raw)
In-Reply-To: <20250512163432.22678-1-lukasz.laguna@intel.com>

Update driver's internal wedged.mode state only in case of a success to
avoid inconsistent state.

Fixes: 6b8ef44cc0a9 ("drm/xe: Introduce the wedged_mode debugfs")
Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 7e14eb037295..2190219177e4 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -170,8 +170,6 @@ static ssize_t wedged_mode_set(struct file *f, const char __user *ubuf,
 	if (xe->wedged.mode == wedged_mode)
 		return size;
 
-	xe->wedged.mode = wedged_mode;
-
 	xe_pm_runtime_get(xe);
 	for_each_gt(gt, xe, id) {
 		ret = xe_guc_ads_scheduler_policy_toggle_reset(&gt->uc.guc.ads);
@@ -183,6 +181,8 @@ static ssize_t wedged_mode_set(struct file *f, const char __user *ubuf,
 	}
 	xe_pm_runtime_put(xe);
 
+	xe->wedged.mode = wedged_mode;
+
 	return size;
 }
 
-- 
2.40.0


  parent reply	other threads:[~2025-05-12 16:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 16:34 [PATCH v2 0/4] drm/xe: Improve wedged mode handling Lukasz Laguna
2025-05-12 16:34 ` [PATCH v2 1/4] drm/xe: Validate wedged_mode parameter and define enum for modes Lukasz Laguna
2025-05-12 17:05   ` Michal Wajdeczko
2025-05-12 16:34 ` Lukasz Laguna [this message]
2025-05-12 16:34 ` [PATCH v2 3/4] drm/xe/vf: Disallow setting wedged_mode=2 Lukasz Laguna
2025-05-12 16:34 ` [PATCH v2 4/4] drm/xe/pf: Allow wedged_mode=2 only in debug config Lukasz Laguna
2025-05-12 17:17 ` ✓ CI.Patch_applied: success for drm/xe: Improve wedged mode handling (rev2) Patchwork
2025-05-12 17:17 ` ✓ CI.checkpatch: " Patchwork
2025-05-12 17:18 ` ✓ CI.KUnit: " Patchwork
2025-05-12 17:28 ` ✗ CI.Build: failure " Patchwork
2025-05-13 12:11 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-13 12:12 ` ✓ CI.checkpatch: " Patchwork
2025-05-13 12:14 ` ✓ CI.KUnit: " Patchwork
2025-05-13 12:28 ` ✓ CI.Build: " Patchwork
2025-05-13 12:31 ` ✗ CI.Hooks: failure " Patchwork
2025-05-13 12:32 ` ✓ CI.checksparse: success " Patchwork
2025-05-13 12:58 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-13 15:10 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512163432.22678-3-lukasz.laguna@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox