From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2871DC3ABC9 for ; Sun, 18 May 2025 06:17:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D52C910E0F3; Sun, 18 May 2025 06:17:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="jbLYb4vZ"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id D85F110E0F3; Sun, 18 May 2025 06:17:12 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8D7A15C31A0; Sun, 18 May 2025 06:14:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0205C4CEE9; Sun, 18 May 2025 06:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747549028; bh=wKeSZPSyX8iX4JyTNeOos4CzlBkoU40E/puTyBr7Mwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jbLYb4vZ/31WsfOV2ChI1GFIpYj5nJXEoUSOEAp8PCh1eHRJna9Et+eDvfrxQVPqV 4m6kcXNhZzAJGtNL0rWAf/8pTv/7p8LoEMkvns3VbVCY0Z8YMzVgcNT0iU7WbjkLYU R35iW4Q0HYQSPRTmu5qnPt9Wz+oIAxKTgThhmrHdkLGmD20c2arat4Mic00afiIOO/ bhIJq0iAt/Pl0enB5YJYMo071YCEhlD1Tk1tcYTA+JPDpB5tP7kuweNDvfnDLRPU1o YCW2xyTYwzGZcGA8kELQEi9UFx77xLPX03Z868Tv2aQKYrNl4zzE+JH/HEZ5wpAa/M q65nhzUrHRDcw== Date: Sun, 18 May 2025 09:17:03 +0300 From: Leon Romanovsky To: "Borah, Chaitanya Kumar" Cc: Jason Gunthorpe , "intel-xe@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "Saarinen, Jani" , "Nikula, Jani" , "Kurmi, Suresh Kumar" , "De Marchi, Lucas" , "iommu@lists.linux.dev" Subject: Re: [REGRESSION] on linux-next (next-20250507) Message-ID: <20250518061703.GB7435@unreal> References: <20250512122102.GF5657@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, May 14, 2025 at 12:40:02PM +0000, Borah, Chaitanya Kumar wrote: > > > > -----Original Message----- > > From: Jason Gunthorpe > > Sent: Monday, May 12, 2025 5:51 PM > > To: Borah, Chaitanya Kumar > > Cc: intel-xe@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Saarinen, > > Jani ; Nikula, Jani ; Kurmi, > > Suresh Kumar ; De Marchi, Lucas > > ; iommu@lists.linux.dev > > Subject: Re: [REGRESSION] on linux-next (next-20250507) > > > > On Mon, May 12, 2025 at 06:00:39AM +0000, Borah, Chaitanya Kumar > > wrote: > > > > > `````````````````````````````````````````````````````````````````````` > > > ``````````````````````````````````` > > > commit 13f43d7cf3e0570004a0d960bc1be23db827c2ff > > > Author: Jason Gunthorpe mailto:jgg@nvidia.com > > > Date:   Tue Apr 8 13:53:56 2025 -0300 > > > > > >     iommu/pages: Formalize the freelist API > > > `````````````````````````````````````````````````````````````````````` > > > ``````````````````````````````````` > > > > > > We could not revert the patch because of merge conflicts but resetting to the > > parent of the commit seems to fix the issue. > > > > > > Could you please check why the patch causes this regression and provide a > > fix if necessary? > > > > Could this be the solution? > > Apologies for the delay, this change seems to solve the issue. Can we expect a patch soon? Jason is on vacation this week. I recommend to submit the patch by itself. Thanks > > Regards > > Chaitanya > > > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > index 0af1ab36283cba..7d2b51a890c75a 100644 > > --- a/drivers/iommu/dma-iommu.c > > +++ b/drivers/iommu/dma-iommu.c > > @@ -154,6 +154,8 @@ static void fq_ring_free_locked(struct > > iommu_dma_cookie *cookie, struct iova_fq > > fq->entries[idx].iova_pfn, > > fq->entries[idx].pages); > > > > + fq->entries[idx].freelist = > > + IOMMU_PAGES_LIST_INIT(fq->entries[idx].freelist); > > fq->head = (fq->head + 1) & fq->mod_mask; > > } > > } > > > > Jason