From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C6E1C54754 for ; Sun, 18 May 2025 06:46:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 740F810E1F4; Sun, 18 May 2025 06:46:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GosMxN7q"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2B1F10E0F5; Sun, 18 May 2025 06:46:00 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 03F37A4C854; Sun, 18 May 2025 06:45:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27BDFC4CEE7; Sun, 18 May 2025 06:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747550754; bh=7RlvzbsKw/dgUSnuBT6EgZlFvU9rYAcIaBft9As+m1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GosMxN7quxZAUvwGIz+CMqVK1FPj8SUEMlg8FoZvirpfDG5WcZ7CkYC2F0j4QFADP Gzb9nxHnoYSKL0E/xoXfZRUB4lbcGHNfZ2xSglf+k0qdbn22/YLRzLTxWRrGpyHp2l lrbzwjoMK5JNYLGqiI7KR99pILVrGxs7K3GIvz0ABxP4oqRHT/yBHJuKtScfEVN3I6 ZLtS+hMXAWLoKxTIYypY347rUbSFfIbd6/I1tp3AjCrj0kDkvkLgEiuk2iaH5U4U99 OmoP5G2yTkOEJ636/zT4sE7okerSG5YL8Q77C/8zMlcZNh1SJBvyZr2JqEqxMGb10c i443PmsfLPDyA== Date: Sun, 18 May 2025 09:45:50 +0300 From: Leon Romanovsky To: "Borah, Chaitanya Kumar" Cc: Jason Gunthorpe , "intel-xe@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "Saarinen, Jani" , "Nikula, Jani" , "Kurmi, Suresh Kumar" , "De Marchi, Lucas" , "iommu@lists.linux.dev" Subject: Re: [REGRESSION] on linux-next (next-20250507) Message-ID: <20250518064550.GD7435@unreal> References: <20250512122102.GF5657@nvidia.com> <20250518061703.GB7435@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250518061703.GB7435@unreal> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, May 18, 2025 at 09:17:03AM +0300, Leon Romanovsky wrote: > On Wed, May 14, 2025 at 12:40:02PM +0000, Borah, Chaitanya Kumar wrote: > > > > > > > -----Original Message----- > > > From: Jason Gunthorpe > > > Sent: Monday, May 12, 2025 5:51 PM > > > To: Borah, Chaitanya Kumar > > > Cc: intel-xe@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Saarinen, > > > Jani ; Nikula, Jani ; Kurmi, > > > Suresh Kumar ; De Marchi, Lucas > > > ; iommu@lists.linux.dev > > > Subject: Re: [REGRESSION] on linux-next (next-20250507) > > > > > > On Mon, May 12, 2025 at 06:00:39AM +0000, Borah, Chaitanya Kumar > > > wrote: > > > > > > > `````````````````````````````````````````````````````````````````````` > > > > ``````````````````````````````````` > > > > commit 13f43d7cf3e0570004a0d960bc1be23db827c2ff > > > > Author: Jason Gunthorpe mailto:jgg@nvidia.com > > > > Date:   Tue Apr 8 13:53:56 2025 -0300 > > > > > > > >     iommu/pages: Formalize the freelist API > > > > `````````````````````````````````````````````````````````````````````` > > > > ``````````````````````````````````` > > > > > > > > We could not revert the patch because of merge conflicts but resetting to the > > > parent of the commit seems to fix the issue. > > > > > > > > Could you please check why the patch causes this regression and provide a > > > fix if necessary? > > > > > > Could this be the solution? > > > > Apologies for the delay, this change seems to solve the issue. Can we expect a patch soon? > > Jason is on vacation this week. I recommend to submit the patch by itself. It was already sent and applied. https://lore.kernel.org/all/0-v1-7d4dfa6140f7+11f04-iommu_freelist_init_jgg@nvidia.com Thanks > > Thanks > > > > > Regards > > > > Chaitanya > > > > > > > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > > > index 0af1ab36283cba..7d2b51a890c75a 100644 > > > --- a/drivers/iommu/dma-iommu.c > > > +++ b/drivers/iommu/dma-iommu.c > > > @@ -154,6 +154,8 @@ static void fq_ring_free_locked(struct > > > iommu_dma_cookie *cookie, struct iova_fq > > > fq->entries[idx].iova_pfn, > > > fq->entries[idx].pages); > > > > > > + fq->entries[idx].freelist = > > > + IOMMU_PAGES_LIST_INIT(fq->entries[idx].freelist); > > > fq->head = (fq->head + 1) & fq->mod_mask; > > > } > > > } > > > > > > Jason >