From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Michal Mrozek <michal.mrozek@intel.com>,
John Harrison <John.C.Harrison@Intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH v2 2/3] drm/xe: Annotate default for guc_log_level param
Date: Fri, 13 Jun 2025 13:00:38 -0700 [thread overview]
Message-ID: <20250613-guc-log-level-v2-2-cb84a63e49fe@intel.com> (raw)
In-Reply-To: <20250613-guc-log-level-v2-0-cb84a63e49fe@intel.com>
Reword the parameter description so it's clear what's the default and
what are the verbose levels.
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/xe/xe_module.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
index 4809afa7ce3f9..192908fa074cb 100644
--- a/drivers/gpu/drm/xe/xe_module.c
+++ b/drivers/gpu/drm/xe/xe_module.c
@@ -18,9 +18,15 @@
#include "xe_observation.h"
#include "xe_sched_job.h"
+#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
+#define DEFAULT_GUC_LOG_LEVEL 3
+#else
+#define DEFAULT_GUC_LOG_LEVEL 1
+#endif
+
struct xe_modparam xe_modparam = {
.probe_display = true,
- .guc_log_level = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? 3 : 1,
+ .guc_log_level = DEFAULT_GUC_LOG_LEVEL,
.force_probe = CONFIG_DRM_XE_FORCE_PROBE,
#ifdef CONFIG_PCI_IOV
.max_vfs = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? ~0 : 0,
@@ -43,7 +49,8 @@ module_param_named(vram_bar_size, xe_modparam.force_vram_bar_size, int, 0600);
MODULE_PARM_DESC(vram_bar_size, "Set the vram bar size (in MiB) - <0=disable-resize, 0=max-needed-size[default], >0=force-size");
module_param_named(guc_log_level, xe_modparam.guc_log_level, int, 0600);
-MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1..5=enable with verbosity min..max)");
+MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1=normal, 2..5=verbose-levels "
+ "[default=" __stringify(DEFAULT_GUC_LOG_LEVEL) "])");
module_param_named_unsafe(guc_firmware_path, xe_modparam.guc_firmware_path, charp, 0400);
MODULE_PARM_DESC(guc_firmware_path,
--
2.49.0
next prev parent reply other threads:[~2025-06-13 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 20:00 [PATCH v2 0/3] drm/xe: Tweak default GuC log level Lucas De Marchi
2025-06-13 20:00 ` [PATCH v2 1/3] drm/xe/guc: Default log level to non-verbose Lucas De Marchi
2025-06-13 20:00 ` Lucas De Marchi [this message]
2025-06-13 20:00 ` [PATCH v2 3/3] drm/xe: Normalize default param values Lucas De Marchi
2025-06-16 18:46 ` John Harrison
2025-06-16 18:52 ` Lucas De Marchi
2025-06-16 19:14 ` John Harrison
2025-06-13 21:52 ` ✗ CI.checkpatch: warning for drm/xe: Tweak default GuC log level (rev2) Patchwork
2025-06-13 21:53 ` ✓ CI.KUnit: success " Patchwork
2025-06-13 22:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-15 21:23 ` ✗ Xe.CI.Full: failure " Patchwork
2025-06-17 23:40 ` [PATCH v2 0/3] drm/xe: Tweak default GuC log level Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613-guc-log-level-v2-2-cb84a63e49fe@intel.com \
--to=lucas.demarchi@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.mrozek@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox