From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B2EBC71155 for ; Fri, 20 Jun 2025 12:09:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EEA010EB51; Fri, 20 Jun 2025 12:09:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="D6Pkzz/b"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 482E310EB51 for ; Fri, 20 Jun 2025 12:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750421397; x=1781957397; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TD2FKEZAVRPdSYuPsVeqdL5F9CICuwpGt6+Qe3OhPFI=; b=D6Pkzz/bEPpCuB+atkWRh1HEfQoi4Igvpts+wchGUxQWISxkDqXPJKgY hOnxlGMWtRURV1hkaVh4b3F7F5sEGss6MbTgjoei44dinOQUGpDBbmnZk Q8BNxmma2BMfqKdYmn6hAzY+VxpFQCaUwSoP4Cd4s74w1MhAX9bwwJ6xi xRd2p3d+wyDPg2q7PTDkFnk1HujqqyEDZULVC85ikc8fMMQxJwcjwrj35 EVBXpdI6F1P5KwZYVqHPzwhoQnP3uryMGZn24Qj61wqEc6HAOf3ceszTN 49HtnR64OrBaPz0J2Vmk3El2eKrddiM3YD8iXvfMpebJYQfqedR9MuGm7 A==; X-CSE-ConnectionGUID: UHT6vGc3TsWuBcZ8f2Yp1Q== X-CSE-MsgGUID: 1Ij4wyB+QUm228ZiiUNGQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="56361831" X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="56361831" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 05:09:57 -0700 X-CSE-ConnectionGUID: IxMr/FibTtKh5RN309quYw== X-CSE-MsgGUID: SpGFA0/VSLKkyJYwr6sJig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="151036750" Received: from psoham-nuc7i7bnh.iind.intel.com ([10.190.216.151]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 05:09:54 -0700 From: Soham Purkait To: intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com, badal.nilawar@intel.com, karthik.poosa@intel.com, riana.tauro@intel.com, jonathan.cavitt@intel.com Cc: lucas.demarchi@intel.com, soham.purkait@intel.com, ashutosh.dixit@intel.com, jani.nikula@intel.com Subject: [PATCH v5 2/2] drm/xe/xe_debugfs: Exposure of G-State and pcie link state residency counters through debugfs Date: Fri, 20 Jun 2025 17:33:56 +0530 Message-Id: <20250620120356.3289744-3-soham.purkait@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250620120356.3289744-1-soham.purkait@intel.com> References: <20250620120356.3289744-1-soham.purkait@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Add debug nodes, "dgfx_pkg_residencies" for G-states (G2, G6, G8, G10, ModS) and "dgfx_pcie_link_residencies" for PCIe link states(L0, L1, L1.2) residency counters. V1 : Expose all G-State residency counter values under dgfx_pkg_residencies. (Anshuman) Included runtime_get/put and removed drm_warn. (Riana) v2 : Moved "dgfx_pkg_residencies" from "/sys/kernel/debug/gtidle/" to "/sys/kernel/debug/". (Anshuman) v3 : Included debugfs node "dgfx_pcie_link_residencies" for pcie link state residency counter values. (Anshuman) v4 : Included check for BMG and dgfx and helper function for repetitive code. (Riana) Used drm_info_list to create the debugfs. (Karthik) v5 : Reordered commits to reflect the correct dependency hierarchy. (Jonathan) Simplification of commit message and rectified register offset. (Karthik) Error handling and return before printing. (Riana) Signed-off-by: Soham Purkait --- drivers/gpu/drm/xe/xe_debugfs.c | 71 +++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c index d83cd6ed3fa8..9e1f753ed1df 100644 --- a/drivers/gpu/drm/xe/xe_debugfs.c +++ b/drivers/gpu/drm/xe/xe_debugfs.c @@ -11,16 +11,19 @@ #include +#include "regs/xe_pmt.h" #include "xe_bo.h" #include "xe_device.h" #include "xe_force_wake.h" #include "xe_gt_debugfs.h" #include "xe_gt_printk.h" #include "xe_guc_ads.h" +#include "xe_mmio.h" #include "xe_pm.h" #include "xe_pxp_debugfs.h" #include "xe_sriov.h" #include "xe_step.h" +#include "xe_vsec.h" #ifdef CONFIG_DRM_XE_DEBUG #include "xe_bo_evict.h" @@ -30,6 +33,23 @@ DECLARE_FAULT_ATTR(gt_reset_failure); +static void read_residency_counter(struct xe_device *xe, struct xe_mmio *mmio, + u32 offset, char *name, struct drm_printer *p) +{ + u64 residency = 0; + int ret; + + ret = xe_pmt_telem_read(to_pci_dev(xe->drm.dev), + xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), + &residency, offset, sizeof(residency)); + if (ret != sizeof(residency)) { + drm_warn(&xe->drm, "%s counter failed to read, ret %d\n", name, ret); + return; + } + + drm_printf(p, "%s : %llu\n", name, residency); +} + static struct xe_device *node_to_xe(struct drm_info_node *node) { return to_xe_device(node->minor->dev); @@ -82,11 +102,57 @@ static int sriov_info(struct seq_file *m, void *data) return 0; } +static int dgfx_pkg_residencies_show(struct seq_file *m, void *data) +{ + struct xe_device *xe; + struct xe_mmio *mmio; + struct drm_printer p; + + xe = node_to_xe(m->private); + p = drm_seq_file_printer(m); + xe_pm_runtime_get(xe); + mmio = xe_root_tile_mmio(xe); + + read_residency_counter(xe, mmio, BMG_G2_RESIDENCY_OFFSET, "Package G2", &p); + read_residency_counter(xe, mmio, BMG_G6_RESIDENCY_OFFSET, "Package G6", &p); + read_residency_counter(xe, mmio, BMG_G8_RESIDENCY_OFFSET, "Package G8", &p); + read_residency_counter(xe, mmio, BMG_G10_RESIDENCY_OFFSET, "Package G10", &p); + read_residency_counter(xe, mmio, BMG_MODS_RESIDENCY_OFFSET, "Package ModS", &p); + xe_pm_runtime_put(xe); + return 0; +} + +static int dgfx_pcie_link_residencies_show(struct seq_file *m, void *data) +{ + struct xe_device *xe; + struct xe_mmio *mmio; + struct drm_printer p; + + xe = node_to_xe(m->private); + p = drm_seq_file_printer(m); + xe_pm_runtime_get(xe); + mmio = xe_root_tile_mmio(xe); + + read_residency_counter(xe, mmio, PCIE_LINK_L0_RESIDENCY_COUNTER, + "PCIE LINK L0 RESIDENCY", &p); + read_residency_counter(xe, mmio, PCIE_LINK_L1_RESIDENCY_COUNTER, + "PCIE LINK L1 RESIDENCY", &p); + read_residency_counter(xe, mmio, PCIE_LINK_L1_2_RESIDENCY_COUNTER, + "PCIE LINK L1.2 RESIDENCY", &p); + xe_pm_runtime_put(xe); + return 0; +} + static const struct drm_info_list debugfs_list[] = { {"info", info, 0}, { .name = "sriov_info", .show = sriov_info, }, }; +static const struct drm_info_list debugfs_residencies[] = { + { .name = "dgfx_pkg_residencies", .show = dgfx_pkg_residencies_show, }, + { .name = "dgfx_pcie_link_residencies", .show = dgfx_pcie_link_residencies_show, }, +}; + static int forcewake_open(struct inode *inode, struct file *file) { struct xe_device *xe = inode->i_private; @@ -240,6 +306,11 @@ void xe_debugfs_register(struct xe_device *xe) ARRAY_SIZE(debugfs_list), root, minor); + if (IS_DGFX(xe) && xe->info.platform == XE_BATTLEMAGE) + drm_debugfs_create_files(debugfs_residencies, + ARRAY_SIZE(debugfs_residencies), + root, minor); + debugfs_create_file("forcewake_all", 0400, root, xe, &forcewake_all_fops); -- 2.34.1