From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: Imre Deak <imre.deak@gmail.com>
Subject: [PATCH 05/20] drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQ
Date: Thu, 26 Jun 2025 11:20:38 +0300 [thread overview]
Message-ID: <20250626082053.219514-6-imre.deak@intel.com> (raw)
In-Reply-To: <20250626082053.219514-1-imre.deak@intel.com>
From: Imre Deak <imre.deak@gmail.com>
Handle the RX_CAP_CHANGED IRQ, which a sink can use to indicate a DPRX
capability change without disconnecting and reconnecting itself (i.e.
through a short vs. long HPD pulse). Handle the IRQ by doing a full
connector detection.
Signed-off-by: Imre Deak <imre.deak@gmail.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 453416b9e9bec..c2eadfa060c2d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5099,7 +5099,7 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
drm_dbg_kms(display->drm, "DPRX ESI: %4ph\n", esi);
- ack[3] |= esi[3] & (LINK_STATUS_CHANGED | DP_TUNNELING_IRQ);
+ ack[3] |= esi[3] & (RX_CAP_CHANGED | LINK_STATUS_CHANGED | DP_TUNNELING_IRQ);
intel_dp_mst_hpd_irq(intel_dp, esi, ack);
@@ -5112,6 +5112,9 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
if (ack[1] & (DP_DOWN_REP_MSG_RDY | DP_UP_REQ_MSG_RDY))
drm_dp_mst_hpd_irq_send_new_request(&intel_dp->mst.mgr);
+ if (ack[3] & RX_CAP_CHANGED)
+ reprobe_needed = true;
+
if ((ack[3] & LINK_STATUS_CHANGED) || intel_dp->link.force_retrain)
intel_dp_check_link_state(intel_dp);
@@ -5424,6 +5427,9 @@ static bool intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
return false;
+ if (val & RX_CAP_CHANGED)
+ reprobe_needed = true;
+
if (val & HDMI_LINK_STATUS_CHANGED)
intel_dp_handle_hdmi_link_status_change(intel_dp);
--
2.44.2
next prev parent reply other threads:[~2025-06-26 8:21 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 8:20 [PATCH 00/20] drm/i915/dp: Fix few SST HPD IRQ handling issues Imre Deak
2025-06-26 8:20 ` [PATCH 01/20] drm/i915/dp_mst: Reprobe connector if the IRQ ESI read failed Imre Deak
2025-06-27 7:42 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 02/20] drm/i915/dp_mst: Verify the link status always the same way Imre Deak
2025-06-26 8:31 ` Jani Nikula
2025-06-27 15:19 ` Imre Deak
2025-07-03 11:14 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 03/20] drm/i915/dp_mst: Reuse intel_dp_check_link_state() in the HPD IRQ handler Imre Deak
2025-07-01 7:50 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 04/20] drm/i915/dp: Handle a tunneling IRQ after acking it Imre Deak
2025-07-01 8:02 ` Luca Coelho
2025-07-01 8:32 ` Imre Deak
2025-07-01 8:47 ` Luca Coelho
2025-06-26 8:20 ` Imre Deak [this message]
2025-07-01 8:03 ` [PATCH 05/20] drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQ Luca Coelho
2025-07-01 10:30 ` Imre Deak
2025-07-03 11:16 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 06/20] drm/i915/dp: Handle the DOWNSTREAM_PORT_STATUS_CHANGED event Imre Deak
2025-07-01 8:52 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 07/20] drm/i915/dp: Don't clobber the encoder state in the HPD IRQ handler Imre Deak
2025-07-01 8:56 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 08/20] drm/i915/dp: Remove the device service IRQ handling from connector detect Imre Deak
2025-07-01 9:00 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 09/20] drm/i915/dp: Fix the device service IRQ DPCD_REV check Imre Deak
2025-07-01 9:01 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 10/20] drm/i915/dp: Fix the link " Imre Deak
2025-07-01 9:12 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 11/20] drm/i915/dp: Reprobe connector if getting/acking device IRQs fails Imre Deak
2025-06-26 9:12 ` Jani Nikula
2025-06-26 9:35 ` Imre Deak
2025-06-26 10:23 ` Jani Nikula
2025-06-26 10:43 ` Imre Deak
2025-06-26 10:46 ` Jani Nikula
2025-06-26 10:56 ` Imre Deak
2025-07-03 11:28 ` Luca Coelho
2025-07-03 11:43 ` Imre Deak
2025-07-07 10:05 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 12/20] drm/i915/dp: Reprobe connector if getting/acking link service " Imre Deak
2025-07-03 11:37 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 13/20] drm/i915/dp: Return early if getting/acking device " Imre Deak
2025-07-03 11:59 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 14/20] drm/i915/dp: Return early if getting/ackink link " Imre Deak
2025-07-03 12:29 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 15/20] drm/i915/dp: Read/ack sink count and sink IRQs for SST as it's done for MST Imre Deak
2025-07-03 13:02 ` Luca Coelho
2025-07-03 13:14 ` Imre Deak
2025-07-03 13:24 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 16/20] drm/i915/dp: Print debug message for a sink connected off request Imre Deak
2025-07-03 13:03 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 17/20] drm/i915/dp: Check SST link status while handling link service IRQs Imre Deak
2025-07-03 13:05 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 18/20] drm/i915/dp_mst: Reuse intel_dp_handle_link_service_irq() Imre Deak
2025-07-03 13:07 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 19/20] drm/i915/dp: Ack only the handled device service IRQs Imre Deak
2025-07-03 13:14 ` Luca Coelho
2025-07-03 13:18 ` Imre Deak
2025-07-03 13:27 ` Imre Deak
2025-07-03 13:34 ` Luca Coelho
2025-06-26 8:20 ` [PATCH 20/20] drm/i915/dp: Ack only the handled link " Imre Deak
2025-07-03 13:18 ` Luca Coelho
2025-06-26 8:37 ` ✓ CI.KUnit: success for drm/i915/dp: Fix few SST HPD IRQ handling issues Patchwork
2025-06-26 8:55 ` ✗ CI.checksparse: warning " Patchwork
2025-06-26 9:18 ` ✓ Xe.CI.BAT: success " Patchwork
2025-06-27 8:21 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626082053.219514-6-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=imre.deak@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox