From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B319CC7EE31 for ; Thu, 26 Jun 2025 13:56:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7613A10E2B2; Thu, 26 Jun 2025 13:56:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Cls6/8YN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8C6810E2B2 for ; Thu, 26 Jun 2025 13:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750946205; x=1782482205; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FSCdKuBZu83ZlNuhWTKve1fHQ1SiZ+gddU/oetdw40o=; b=Cls6/8YNnpqjvDG3GbAFrcQlKzHrDUjIZ8wn73umrlpkLrTLAYbJKCNg gtTemHySYwS74pk8fnHIKUg5MqdsOw5Nw4BY3Jq9TNgQL1es2wX2X24He 7yzj6345DmbHvxabVk/MbHkCJ2WLsYbNoeFviq85eMPQrltXbD0lWZS/R Px85drQsr/eMTLVj1suyHnwYqXmoq+MB8hhiWdLxzTnbkXIGgT/8EELCk kOiGhNMG8+XkkzCIkOhdq92HRZk/B3Ix7eHtGUU84MSycl1g3nLrWESXq x6WoESDyCMvcdQlugV5xiuJ8OTAC4IG8M+b50Y6oXsShhoGvy5zzPpJQf g==; X-CSE-ConnectionGUID: 6kYyKG0NQyWWFOTge5goJw== X-CSE-MsgGUID: lP9MVCaFSLev1utmuU9CSw== X-IronPort-AV: E=McAfee;i="6800,10657,11475"; a="53316435" X-IronPort-AV: E=Sophos;i="6.16,267,1744095600"; d="scan'208";a="53316435" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2025 06:56:34 -0700 X-CSE-ConnectionGUID: 09+Pw5CDQx2o0FEHa7ZAsg== X-CSE-MsgGUID: aQiaTLYjRf2OjVS5zgbIZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,267,1744095600"; d="scan'208";a="152146975" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmviesa007.fm.intel.com with ESMTP; 26 Jun 2025 06:56:29 -0700 From: Heikki Krogerus To: Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi Cc: Jarkko Nikula , David Airlie , Simona Vetter , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Raag Jadav , "Tauro, Riana" , "Adatrao, Srinivasa" , "Michael J. Ruhl" , intel-xe@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 4/4] drm/xe/xe_i2c: Add support for i2c in survivability mode Date: Thu, 26 Jun 2025 16:56:09 +0300 Message-ID: <20250626135610.299943-5-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250626135610.299943-1-heikki.krogerus@linux.intel.com> References: <20250626135610.299943-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Riana Tauro Initialize i2c in survivability mode to allow firmware update of Add-In Management Controller (AMC) in survivability mode Signed-off-by: Riana Tauro Reviewed-by: Raag Jadav Signed-off-by: Heikki Krogerus --- drivers/gpu/drm/xe/xe_survivability_mode.c | 23 ++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c index 1f710b3fc599..3800cc855c22 100644 --- a/drivers/gpu/drm/xe/xe_survivability_mode.c +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c @@ -14,6 +14,7 @@ #include "xe_device.h" #include "xe_gt.h" #include "xe_heci_gsc.h" +#include "xe_i2c.h" #include "xe_mmio.h" #include "xe_pcode_api.h" #include "xe_vsec.h" @@ -173,20 +174,26 @@ static int enable_survivability_mode(struct pci_dev *pdev) survivability->mode = true; ret = xe_heci_gsc_init(xe); - if (ret) { - /* - * But if it fails, device can't enter survivability - * so move it back for correct error handling - */ - survivability->mode = false; - return ret; - } + if (ret) + goto err; xe_vsec_init(xe); + ret = xe_i2c_probe(xe); + if (ret) + goto err; + dev_err(dev, "In Survivability Mode\n"); return 0; + +err: + /* + * But if it fails, device can't enter survivability + * so move it back for correct error handling + */ + survivability->mode = false; + return ret; } /** -- 2.47.2