From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Zhanjun Dong <zhanjun.dong@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH 1/2] drm/xe: Remove unused code in devcoredump_snapshot()
Date: Thu, 3 Jul 2025 06:20:26 +0000 [thread overview]
Message-ID: <20250703062024.3441918-5-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20250703062024.3441918-4-shuicheng.lin@intel.com>
The deleted code is no longer needed bacause patch ecb633646391("drm/xe/guc: Plumb GuC-capture
into dev coredump") has removed the related usage code.
Remove the code to tidy up the function.
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_devcoredump.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 7a8af2311318..94625010abc4 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -313,13 +313,9 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump,
{
struct xe_devcoredump_snapshot *ss = &coredump->snapshot;
struct xe_guc *guc = exec_queue_to_guc(q);
- u32 adj_logical_mask = q->logical_mask;
- u32 width_mask = (0x1 << q->width) - 1;
const char *process_name = "no process";
-
unsigned int fw_ref;
bool cookie;
- int i;
ss->snapshot_time = ktime_get_real();
ss->boot_time = ktime_get_boottime();
@@ -335,14 +331,6 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump,
INIT_WORK(&ss->work, xe_devcoredump_deferred_snap_work);
cookie = dma_fence_begin_signalling();
- for (i = 0; q->width > 1 && i < XE_HW_ENGINE_MAX_INSTANCE;) {
- if (adj_logical_mask & BIT(i)) {
- adj_logical_mask |= width_mask << i;
- i += q->width;
- } else {
- ++i;
- }
- }
/* keep going if fw fails as we still want to save the memory and SW data */
fw_ref = xe_force_wake_get(gt_to_fw(q->gt), XE_FORCEWAKE_ALL);
--
2.49.0
next prev parent reply other threads:[~2025-07-03 6:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 6:20 [PATCH 0/2] Remove unused code in devcoredump_snapshot Shuicheng Lin
2025-07-03 6:20 ` Shuicheng Lin [this message]
2025-07-03 6:20 ` [PATCH 2/2] drm/xe: Release runtime pm for error path of xe_devcoredump_read() Shuicheng Lin
2025-07-03 6:57 ` Matthew Brost
2025-07-03 7:01 ` Matthew Brost
2025-07-03 6:29 ` ✗ CI.checkpatch: warning for Remove unused code in devcoredump_snapshot Patchwork
2025-07-03 6:30 ` ✓ CI.KUnit: success " Patchwork
2025-07-03 7:41 ` [PATCH v2 0/2] Remove unused code in devcoredump_snapshot() Shuicheng Lin
2025-07-03 7:41 ` [PATCH v2 1/2] drm/xe: " Shuicheng Lin
2025-07-03 14:38 ` Dong, Zhanjun
2025-07-03 15:35 ` Matthew Brost
2025-07-03 7:41 ` [PATCH v2 2/2] drm/xe: Release runtime pm for error path of xe_devcoredump_read() Shuicheng Lin
2025-07-03 15:34 ` Matthew Brost
2025-07-04 5:56 ` ✗ CI.checkpatch: warning for Remove unused code in devcoredump_snapshot (rev2) Patchwork
2025-07-04 5:57 ` ✓ CI.KUnit: success " Patchwork
2025-07-04 20:01 ` ✗ Xe.CI.Full: failure for Remove unused code in devcoredump_snapshot Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703062024.3441918-5-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox