From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5198BC83030 for ; Thu, 3 Jul 2025 07:42:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FB5210E7DA; Thu, 3 Jul 2025 07:42:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HiFgPqMd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8600810E7DA for ; Thu, 3 Jul 2025 07:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751528555; x=1783064555; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jR2fb7Wh9ayAPPeV36JDgi4AS1cI59UD6pDxGae7OWM=; b=HiFgPqMdcUSLLjGvho1mO642B40YIqM3eTZ5GZUxdjOgqIm+E9PCiiyk Vt/BONM36haGu/OpnLWTy/pwCbrryrkWiYVcHv8U20MUjhmtNsH6YJqaJ g0S1J293bEld1kOPWANL2K3m8RCuSAgCchHUNefuG28w/pVovIgTBidiP d3MK40rQa1qLd8gz+Plk5Ex+4QtZ2W1bnby+SjCrcmHDDoF3oKcnyRZsD NnJlJN3dHI3whf+5QkStkkkvNKpoDLiDvBTsbowu8vI34IajWVtsqqMI/ I86LqEsNO6IRn1hVpPsmVcivX06G9dDewhicroTXcn5mh3wh2iva4tCXF A==; X-CSE-ConnectionGUID: +1G8RVhJS4GZPRVgClttwA== X-CSE-MsgGUID: IRCbWO8PQteA5cmmiRRCvA== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="53938236" X-IronPort-AV: E=Sophos;i="6.16,283,1744095600"; d="scan'208";a="53938236" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2025 00:42:35 -0700 X-CSE-ConnectionGUID: hW+8Q+C0S0GhBMxtTXyA0Q== X-CSE-MsgGUID: zQhWdmOjQzmHEc1WECazOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,283,1744095600"; d="scan'208";a="155043714" Received: from osgc-linux-buildserver.sh.intel.com ([10.112.232.103]) by fmviesa010.fm.intel.com with ESMTP; 03 Jul 2025 00:42:34 -0700 From: Shuicheng Lin To: intel-xe@lists.freedesktop.org Cc: matthew.brost@intel.com, Shuicheng Lin , Zhanjun Dong , Rodrigo Vivi Subject: [PATCH v2 1/2] drm/xe: Remove unused code in devcoredump_snapshot() Date: Thu, 3 Jul 2025 07:41:07 +0000 Message-ID: <20250703074105.3461107-5-shuicheng.lin@intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250703074105.3461107-4-shuicheng.lin@intel.com> References: <20250703062024.3441918-4-shuicheng.lin@intel.com> <20250703074105.3461107-4-shuicheng.lin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The deleted code is no longer needed bacause patch ecb633646391("drm/xe/guc: Plumb GuC-capture into dev coredump") has removed the related usage code. Remove the code to tidy up the function. Cc: Zhanjun Dong Cc: Rodrigo Vivi Signed-off-by: Shuicheng Lin --- drivers/gpu/drm/xe/xe_devcoredump.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c index 7a8af2311318..94625010abc4 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -313,13 +313,9 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump, { struct xe_devcoredump_snapshot *ss = &coredump->snapshot; struct xe_guc *guc = exec_queue_to_guc(q); - u32 adj_logical_mask = q->logical_mask; - u32 width_mask = (0x1 << q->width) - 1; const char *process_name = "no process"; - unsigned int fw_ref; bool cookie; - int i; ss->snapshot_time = ktime_get_real(); ss->boot_time = ktime_get_boottime(); @@ -335,14 +331,6 @@ static void devcoredump_snapshot(struct xe_devcoredump *coredump, INIT_WORK(&ss->work, xe_devcoredump_deferred_snap_work); cookie = dma_fence_begin_signalling(); - for (i = 0; q->width > 1 && i < XE_HW_ENGINE_MAX_INSTANCE;) { - if (adj_logical_mask & BIT(i)) { - adj_logical_mask |= width_mask << i; - i += q->width; - } else { - ++i; - } - } /* keep going if fw fails as we still want to save the memory and SW data */ fw_ref = xe_force_wake_get(gt_to_fw(q->gt), XE_FORCEWAKE_ALL); -- 2.49.0